Skip to content

refactor(ci): Consolidate cron jobs #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 4, 2025
Merged

refactor(ci): Consolidate cron jobs #15273

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9e89ea6
refactor(ci): Consolidate cron jobs
ncooke3 Aug 29, 2025
c6f5725
abtesting, app distro, and auth
ncooke3 Aug 29, 2025
3146252
more refactors
ncooke3 Sep 2, 2025
41a1f70
Add dependent triggers
ncooke3 Sep 2, 2025
80456f6
fis
ncooke3 Sep 2, 2025
6bdace9
others
ncooke3 Sep 2, 2025
a56c6d0
revert
ncooke3 Sep 2, 2025
c826b6b
Update .github/workflows/common_cocoapods_cron.yml
ncooke3 Sep 4, 2025
c30d1b1
Update .github/workflows/common_cocoapods_cron.yml
ncooke3 Sep 4, 2025
d381455
work
ncooke3 Sep 4, 2025
8d7984a
work 1
ncooke3 Sep 4, 2025
ccb1eae
auth
ncooke3 Sep 4, 2025
e8387b0
Update .github/workflows/appdistribution.yml
ncooke3 Sep 4, 2025
22760d3
Update .github/workflows/appdistribution.yml
ncooke3 Sep 4, 2025
fec5a22
Update .github/workflows/auth.yml
ncooke3 Sep 4, 2025
5ca6807
Update .github/workflows/common_cocoapods_cron.yml
ncooke3 Sep 4, 2025
0bd274f
Update .github/workflows/common_cocoapods_cron.yml
ncooke3 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 63 additions & 78 deletions .github/workflows/abtesting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,96 +14,81 @@ on:
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_quickstart.yml'
- '.github/workflows/common_cocoapods_cron.yml'
- 'Gemfile*'
schedule:
# Run every day at 2am (PDT) / 5am (EDT) - cron uses UTC times
- cron: '0 9 * * *'

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true
# concurrency:
# group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
# cancel-in-progress: true

jobs:
spm:
uses: ./.github/workflows/common.yml
with:
target: ABTestingUnit
# spm:
# uses: ./.github/workflows/common.yml
# with:
# target: ABTestingUnit

catalyst:
uses: ./.github/workflows/common_catalyst.yml
with:
product: FirebaseABTesting
target: FirebaseABTesting-Unit-unit
# catalyst:
# uses: ./.github/workflows/common_catalyst.yml
# with:
# product: FirebaseABTesting
# target: FirebaseABTesting-Unit-unit

pod_lib_lint:
uses: ./.github/workflows/common_cocoapods.yml
with:
product: FirebaseABTesting
# pod_lib_lint:
# uses: ./.github/workflows/common_cocoapods.yml
# with:
# product: FirebaseABTesting

quickstart:
uses: ./.github/workflows/common_quickstart.yml
with:
product: ABTesting
is_legacy: true
setup_command: scripts/setup_quickstart.sh abtesting
plist_src_path: scripts/gha-encrypted/qs-database.plist.gpg
plist_dst_path: quickstart-ios/database/GoogleService-Info.plist
secrets:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# quickstart:
# uses: ./.github/workflows/common_quickstart.yml
# with:
# product: ABTesting
# is_legacy: true
# setup_command: scripts/setup_quickstart.sh abtesting
# plist_src_path: scripts/gha-encrypted/qs-database.plist.gpg
# plist_dst_path: quickstart-ios/database/GoogleService-Info.plist
# secrets:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}

quickstart-ftl-cron-only:
# Don't run on private repo.
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
# quickstart-ftl-cron-only:
# # Don't run on private repo.
# if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'

env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Setup quickstart
env:
LEGACY: true
run: scripts/setup_quickstart.sh abtesting
- name: Install Secret GoogleService-Info.plist
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-abtesting.plist.gpg \
quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret"
- name: Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
- name: Build swift quickstart
env:
LEGACY: true
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh ABTesting)
- id: ftl_test
uses: FirebaseExtended/github-actions/[email protected]
with:
credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
testapp_dir: quickstart-ios/build-for-testing
test_type: "xctest"
# env:
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
# runs-on: macos-15
# steps:
# - uses: actions/checkout@v4
# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
# - uses: actions/setup-python@v5
# with:
# python-version: '3.11'
# - name: Setup quickstart
# env:
# LEGACY: true
# run: scripts/setup_quickstart.sh abtesting
# - name: Install Secret GoogleService-Info.plist
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-abtesting.plist.gpg \
# quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret"
# - name: Xcode
# run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
# - name: Build swift quickstart
# env:
# LEGACY: true
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh ABTesting)
# - id: ftl_test
# uses: FirebaseExtended/github-actions/[email protected]
# with:
# credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
# testapp_dir: quickstart-ios/build-for-testing
# test_type: "xctest"

abtesting-cron-only:
# Don't run on private repo.
if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'

runs-on: macos-15
strategy:
matrix:
target: [ios, tvos, macos]
flags: [
'--use-static-frameworks'
]
needs: pod_lib_lint
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
- name: Setup Bundler
run: scripts/setup_bundler.sh
- name: Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
- name: PodLibLint ABTesting Cron
run: |
scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb \
FirebaseABTesting.podspec --platforms=${{ matrix.target }} ${{ matrix.flags }}
uses: ./.github/workflows/common_cocoapods_cron.yml
with:
product: FirebaseABTesting
platforms: '[ "ios", "tvos", "macos" ]'
flags: '[ "--use-static-frameworks" ]'
66 changes: 26 additions & 40 deletions .github/workflows/appdistribution.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,53 +12,39 @@ on:
- '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_cocoapods_cron.yml'
- 'Gemfile*'
schedule:
# Run every day at 2am (PDT) / 5am (EDT) - cron uses UTC times
- cron: '0 9 * * *'

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true
# concurrency:
# group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
# cancel-in-progress: true

jobs:
spm:
uses: ./.github/workflows/common.yml
with:
target: AppDistributionUnit
platforms: iOS

catalyst:
uses: ./.github/workflows/common_catalyst.yml
with:
product: FirebaseAppDistribution
target: FirebaseAppDistribution-Unit-unit

pod_lib_lint:
uses: ./.github/workflows/common_cocoapods.yml
with:
product: FirebaseAppDistribution
platforms: iOS # App Distro only supports iOS.
# spm:
# uses: ./.github/workflows/common.yml
# with:
# target: AppDistributionUnit
# platforms: iOS

# catalyst:
# uses: ./.github/workflows/common_catalyst.yml
# with:
# product: FirebaseAppDistribution
# target: FirebaseAppDistribution-Unit-unit

# pod_lib_lint:
# uses: ./.github/workflows/common_cocoapods.yml
# with:
# product: FirebaseAppDistribution
# platforms: iOS # App Distro only supports iOS.

appdistribution-cron-only:
if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'

runs-on: macos-15
strategy:
matrix:
target: [ios]
flags: [
'--use-static-frameworks'
]
needs: pod_lib_lint
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
- name: Setup Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
- name: Setup Bundler
run: scripts/setup_bundler.sh
- name: PodLibLint App Distribution Cron
run: |
scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseAppDistribution.podspec \
--platforms=${{ matrix.target }} ${{ matrix.flags }}
uses: ./.github/workflows/common_cocoapods_cron.yml
with:
product: FirebaseAppDistribution
platforms: '[ "ios" ]'
flags: '[ "--use-static-frameworks" ]'
Loading
Loading