Skip to content

Defensive access to MIMEType #15318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Defensive access to MIMEType #15318

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0be228
Defensive access to MIMEType
JesusRojass Sep 11, 2025
898e575
Update FirebasePerformance/Sources/Instrumentation/FPRNetworkTrace.m
JesusRojass Sep 11, 2025
4594fa2
Style check
JesusRojass Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions FirebasePerformance/Sources/Instrumentation/FPRNetworkTrace.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,14 @@ - (void)didCompleteRequestWithResponse:(NSURLResponse *)response error:(NSError
self.responseCode = (int32_t)HTTPResponse.statusCode;
}
self.responseError = error;
// Safely copy MIMEType to prevent use after free
NSString *mime = [response.MIMEType copy];
// Defensive access to MIMEType
NSString *mime = nil;
@try {
// Safely copy MIMEType to prevent use after free
mime = [response.MIMEType copy];
} @catch (NSException *exception) {
mime = nil;
}
self.responseContentType = (mime.length ? mime : nil);
[self checkpointState:FPRNetworkTraceCheckpointStateResponseCompleted];

Expand Down