[Firebase AI] Replace LiveServerMessage struct/enum with protocol #15365
+2,351
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f0f9e4d.
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Andrew Heard <[email protected]>
…ntContent.swift Co-authored-by: Andrew Heard <[email protected]>
…ntMessage.swift Co-authored-by: Andrew Heard <[email protected]>
…ntMessage.swift Co-authored-by: Andrew Heard <[email protected]>
Co-authored-by: Andrew Heard <[email protected]>
Co-authored-by: Andrew Heard <[email protected]>
Co-authored-by: Andrew Heard <[email protected]>
Co-authored-by: Andrew Heard <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
…e-ios-sdk into dlr/firebaseai-live-api
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors LiveServerMessage from a struct with an enum to a protocol. This is an excellent change that improves the extensibility of the API, allowing for new message types to be added without causing breaking changes. The implementation is solid and consistently applied across all relevant files. The related changes, such as improving error handling during session setup and adding a new API test, are also valuable. I have a couple of minor suggestions to improve code style consistency and make the new test more robust. Overall, great work on this refactoring!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the
LiveServerMessagestruct containing theMessageTypeenum with a protocol. This avoids potential breaking changes if new message types need to be added.#no-changelog