Skip to content

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Oct 2, 2025

Per b/448722577,

This adjusts the websocket url to use the user configured location, instead of hardcoding to us-central1. While us-central1 is currently the only supported location, we should still use the user configured location; as down stream consumers may have location constraints. So instead of override the location, we allow the model to surface an error to consumers about their location being unsupported.

To help propagate the location down to the LiveSessionService, I opted to move the location variable to live under the APIConfig struct, instead of being a hanging property on FirebaseAI.

#no-changelog

@daymxn daymxn requested review from andrewheard and ncooke3 October 2, 2025 18:13
@daymxn daymxn self-assigned this Oct 2, 2025
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@daymxn daymxn enabled auto-merge (squash) October 2, 2025 18:14
@daymxn daymxn disabled auto-merge October 2, 2025 18:30
@ncooke3 ncooke3 added this to the 12.4.0 - M171 milestone Oct 2, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively refactors how the location is handled by moving it into the APIConfig struct. This makes the configuration more cohesive and allows the websocket endpoint to correctly use the user-configured location instead of a hardcoded value. The changes are consistently applied across the codebase, including initializers, instance management, and tests. The code quality is high, and I only have a couple of minor suggestions for cleanup.

@andrewheard
Copy link
Contributor

I checked in the xcodebuild-test.log and it's only the URL Context tests that are failing in the integration tests job (known issue).

@andrewheard andrewheard requested a review from ncooke3 October 2, 2025 21:30
@daymxn daymxn merged commit 8314558 into main Oct 2, 2025
43 of 49 checks passed
@daymxn daymxn deleted the dlr/fix-live-location branch October 2, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants