Skip to content

chore(m172): Update firestore target for release #15374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2025
Merged

chore(m172): Update firestore target for release #15374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a8ea93f
Update firestore target
daymxn Oct 2, 2025
efbedba
Add changelog entry
daymxn Oct 2, 2025
69e10b5
ci(spm): upload xcodebuild logs on failure
ncooke3 Oct 2, 2025
317dd72
Syntax
ncooke3 Oct 2, 2025
a10942a
Upload build logs for new failing job
ncooke3 Oct 2, 2025
eef4b4c
potentially prints error in ci, idk
ncooke3 Oct 2, 2025
dd781da
Revert "potentially prints error in ci, idk"
ncooke3 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/spm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ jobs:
run: scripts/setup_spm_tests.sh
- name: iOS Device and Test Build
run: scripts/third_party/travis/retry.sh ./scripts/build.sh Firebase-Package iOS-device spmbuildonly
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: spm-ios-device-${{ matrix.os }}-${{ matrix.xcode }}-xcodebuild-build.log
path: xcodebuild-build.log

platforms:
# Don't run on private repo unless it is a PR.
Expand Down Expand Up @@ -148,3 +153,9 @@ jobs:
run: scripts/third_party/travis/retry.sh ./scripts/build.sh version-test ${{ matrix.target }} spm
- name: Analytics Build Tests
run: scripts/third_party/travis/retry.sh ./scripts/build.sh analytics-import-test ${{ matrix.target }} spm
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: spm-platforms-${{ matrix.target }}-${{ matrix.os }}-${{ matrix.xcode }}-logs
path: xcodebuild-*.log

4 changes: 4 additions & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 12.4.0
- [fixed] Implemented an internal workaround to fix
[CVE-2025-0838](https://nvd.nist.gov/vuln/detail/CVE-2025-0838). (#15300)

# 12.1.0
- [fixed] Fixed accidental removal of `pod "Firebase/Firestore"` for tvOS in 12.0.0.

Expand Down
4 changes: 2 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1566,8 +1566,8 @@ func firestoreTargets() -> [Target] {
} else {
return .binaryTarget(
name: "FirebaseFirestoreInternal",
url: "https://dl.google.com/firebase/ios/bin/firestore/12.0.0/rc0/FirebaseFirestoreInternal.zip",
checksum: "e7add08e9044ef45f7923d0b9ea5518ddc66b090d3f7e9455382f769e74c48c4"
url: "https://dl.google.com/firebase/ios/bin/firestore/12.4.0/rc0/FirebaseFirestoreInternal.zip",
checksum: "58b916624c01a56c5de694cfc9c5cc7aabcafb13b54e7bde8c83bacc51a3460d"
)
}
}()
Expand Down
Loading