Skip to content

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 17, 2025

  • Refactored ServerPromptTemplateIntegrationTests from XCTest to Swift Testing.
    • Prepared the tests for parameterization.
  • Added the keychain-access-groups entitlement to fix Keychain access on macOS (needed for App Check).

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of refactoring the ServerPromptTemplateIntegrationTests from XCTest to the new Swift Testing framework. The adoption of parameterized tests and the #require and #expect macros has significantly cleaned up the test code, making it more concise and readable. The addition of the keychain-access-groups entitlement is also a necessary fix for running on macOS. I have a few suggestions to further improve the code.

@andrewheard andrewheard requested a review from paulb777 October 17, 2025 16:59
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit 1840566 into pb-spt Oct 17, 2025
60 checks passed
@paulb777 paulb777 deleted the ah/firebaseai-spt branch October 17, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants