-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: messaging cron #15530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: messaging cron #15530
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0f1c1c7
fix: messaging cron
ncooke3 8d808e3
fix
ncooke3 bc57179
SPM=true
ncooke3 1c4e066
skip ruby, skip retry
ncooke3 9308e58
fix unbounded var
ncooke3 1a2af29
checkout pending branch
ncooke3 10ef7f9
remove double build
ncooke3 00b2918
Apply suggestions from code review
ncooke3 596ce40
Apply suggestion from @ncooke3
ncooke3 35514ce
Apply suggestions from code review
ncooke3 4942e00
Update scripts/test_quickstart_ftl.sh
ncooke3 86865a3
Update .github/workflows/messaging.yml
ncooke3 8176972
Update .github/workflows/messaging.yml
ncooke3 f8219e3
revert
ncooke3 b8b328d
Apply suggestion from @ncooke3
ncooke3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,183 +32,180 @@ concurrency: | |
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| spm: | ||
| uses: ./.github/workflows/common.yml | ||
| with: | ||
| target: MessagingUnit | ||
| buildonly_platforms: tvOS, macOS, watchOS, catalyst, visionOS | ||
| # spm: | ||
| # uses: ./.github/workflows/common.yml | ||
| # with: | ||
| # target: MessagingUnit | ||
| # buildonly_platforms: tvOS, macOS, watchOS, catalyst, visionOS | ||
|
|
||
| catalyst: | ||
| uses: ./.github/workflows/common_catalyst.yml | ||
| with: | ||
| product: FirebaseMessaging | ||
| target: FirebaseMessaging-Unit-unit | ||
| # catalyst: | ||
| # uses: ./.github/workflows/common_catalyst.yml | ||
| # with: | ||
| # product: FirebaseMessaging | ||
| # target: FirebaseMessaging-Unit-unit | ||
|
|
||
| pod_lib_lint: | ||
| strategy: | ||
| matrix: | ||
| product: [FirebaseMessagingInterop, FirebaseMessaging] | ||
| uses: ./.github/workflows/common_cocoapods.yml | ||
| with: | ||
| product: ${{ matrix.product }} | ||
| # pod_lib_lint: | ||
| # strategy: | ||
| # matrix: | ||
| # product: [FirebaseMessagingInterop, FirebaseMessaging] | ||
| # uses: ./.github/workflows/common_cocoapods.yml | ||
| # with: | ||
| # product: ${{ matrix.product }} | ||
|
|
||
| # TODO(#12205) Update the build.sh script for this job from "test" instead of "build" | ||
| messaging-integration-tests: | ||
| # Don't run on private repo unless it is a PR. | ||
| if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| env: | ||
| plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| runs-on: macos-15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| with: | ||
| cache_key: integration | ||
| - name: Configure test keychain | ||
| run: scripts/configure_test_keychain.sh | ||
| - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Setup Bundler | ||
| run: scripts/setup_bundler.sh | ||
| - name: Install xcpretty | ||
| run: gem install xcpretty | ||
| - name: Install Secret GoogleService-Info.plist | ||
| run: | | ||
| mkdir FirebaseMessaging/Tests/IntegrationTests/Resources | ||
| scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| FirebaseMessaging/Tests/IntegrationTests/Resources/GoogleService-Info.plist "$plist_secret" | ||
| - name: BuildAndTest | ||
| run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/build.sh Messaging all) | ||
| # # TODO(#12205) Update the build.sh script for this job from "test" instead of "build" | ||
| # messaging-integration-tests: | ||
| # # Don't run on private repo unless it is a PR. | ||
| # if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| # env: | ||
| # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| # runs-on: macos-15 | ||
| # steps: | ||
| # - uses: actions/checkout@v4 | ||
| # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| # with: | ||
| # cache_key: integration | ||
| # - name: Configure test keychain | ||
| # run: scripts/configure_test_keychain.sh | ||
| # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| # - name: Xcode | ||
| # run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| # - name: Setup Bundler | ||
| # run: scripts/setup_bundler.sh | ||
| # - name: Install xcpretty | ||
| # run: gem install xcpretty | ||
| # - name: Install Secret GoogleService-Info.plist | ||
| # run: | | ||
| # mkdir FirebaseMessaging/Tests/IntegrationTests/Resources | ||
| # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| # FirebaseMessaging/Tests/IntegrationTests/Resources/GoogleService-Info.plist "$plist_secret" | ||
| # - name: BuildAndTest | ||
| # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/build.sh Messaging all) | ||
|
|
||
| quickstart: | ||
| uses: ./.github/workflows/common_quickstart.yml | ||
| with: | ||
| product: Messaging | ||
| setup_command: scripts/setup_quickstart_spm.sh messaging | ||
| plist_src_path: scripts/gha-encrypted/qs-messaging.plist.gpg | ||
| plist_dst_path: quickstart-ios/messaging/GoogleService-Info.plist | ||
| run_tests: false | ||
| secrets: | ||
| plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| # quickstart: | ||
| # uses: ./.github/workflows/common_quickstart.yml | ||
| # with: | ||
| # product: Messaging | ||
| # setup_command: scripts/setup_quickstart_spm.sh messaging | ||
| # plist_src_path: scripts/gha-encrypted/qs-messaging.plist.gpg | ||
| # plist_dst_path: quickstart-ios/messaging/GoogleService-Info.plist | ||
| # run_tests: false | ||
| # secrets: | ||
| # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
|
|
||
| quickstart-ftl-cron-only: | ||
| # Don't run on private repo. | ||
| if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule' | ||
| # if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule' | ||
| if: github.repository == 'Firebase/firebase-ios-sdk' | ||
| env: | ||
| plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| runs-on: macos-15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
ncooke3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.11' | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Setup quickstart | ||
| run: scripts/setup_quickstart.sh messaging | ||
| run: QUICKSTART_BRANCH=nc/bft scripts/setup_quickstart_spm.sh messaging | ||
ncooke3 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - name: Install Secret GoogleService-Info.plist | ||
| run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-messaging.plist.gpg \ | ||
| quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret" | ||
| - name: Build objc quickstart | ||
| - name: Build quickstart | ||
| run: ([ -z $plist_secret ] || | ||
| scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Messaging) | ||
| - name: Build swift quickstart | ||
| run: ([ -z $plist_secret ] || | ||
| scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Messaging swift) | ||
| - id: ftl_test | ||
| uses: FirebaseExtended/github-actions/[email protected] | ||
| with: | ||
| credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }} | ||
| testapp_dir: quickstart-ios/build-for-testing | ||
| test_type: "xctest" | ||
|
|
||
| messaging-cron-only: | ||
| uses: ./.github/workflows/common_cocoapods_cron.yml | ||
| with: | ||
| product: FirebaseMessaging | ||
| platforms: '[ "ios", "tvos", "macos --skip-tests", "watchos --skip-tests" ]' | ||
| flags: '[ "--use-static-frameworks" ]' | ||
| # messaging-cron-only: | ||
| # uses: ./.github/workflows/common_cocoapods_cron.yml | ||
| # with: | ||
| # product: FirebaseMessaging | ||
| # platforms: '[ "ios", "tvos", "macos --skip-tests", "watchos --skip-tests" ]' | ||
| # flags: '[ "--use-static-frameworks" ]' | ||
|
|
||
| messaging-sample-build-test: | ||
| # Don't run on private repo unless it is a PR. | ||
| if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| env: | ||
| plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| runs-on: macos-15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| with: | ||
| cache_key: sample${{ matrix.os }} | ||
| - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Setup Bundler | ||
| run: scripts/setup_bundler.sh | ||
| - name: Install Secret GoogleService-Info.plist | ||
| run: | | ||
| scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| FirebaseMessaging/Apps/Shared/GoogleService-Info.plist "$plist_secret" | ||
| - name: Prereqs | ||
| run: scripts/install_prereqs.sh MessagingSample iOS | ||
| - name: Build | ||
| run: ([ -z $plist_secret ] || scripts/build.sh MessagingSample iOS) | ||
| # messaging-sample-build-test: | ||
| # # Don't run on private repo unless it is a PR. | ||
| # if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| # env: | ||
| # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| # runs-on: macos-15 | ||
| # steps: | ||
| # - uses: actions/checkout@v4 | ||
| # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| # with: | ||
| # cache_key: sample${{ matrix.os }} | ||
| # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| # - name: Xcode | ||
| # run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| # - name: Setup Bundler | ||
| # run: scripts/setup_bundler.sh | ||
| # - name: Install Secret GoogleService-Info.plist | ||
| # run: | | ||
| # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| # FirebaseMessaging/Apps/Shared/GoogleService-Info.plist "$plist_secret" | ||
| # - name: Prereqs | ||
| # run: scripts/install_prereqs.sh MessagingSample iOS | ||
| # - name: Build | ||
| # run: ([ -z $plist_secret ] || scripts/build.sh MessagingSample iOS) | ||
|
|
||
| messaging-swiftui-sample-build-test: | ||
| # Don't run on private repo unless it is a PR. | ||
| if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| env: | ||
| plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| runs-on: macos-15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| with: | ||
| cache_key: sample${{ matrix.os }} | ||
| - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| - name: Setup Bundler | ||
| run: scripts/setup_bundler.sh | ||
| - name: Install Secret GoogleService-Info.plist | ||
| run: | | ||
| scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| FirebaseMessaging/Apps/Shared/GoogleService-Info.plist "$plist_secret" | ||
| - name: Prereqs | ||
| run: scripts/install_prereqs.sh SwiftUISample iOS | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Build | ||
| run: ([ -z $plist_secret ] || scripts/build.sh SwiftUISample iOS) | ||
| # messaging-swiftui-sample-build-test: | ||
| # # Don't run on private repo unless it is a PR. | ||
| # if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| # env: | ||
| # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| # runs-on: macos-15 | ||
| # steps: | ||
| # - uses: actions/checkout@v4 | ||
| # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| # with: | ||
| # cache_key: sample${{ matrix.os }} | ||
| # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| # - name: Setup Bundler | ||
| # run: scripts/setup_bundler.sh | ||
| # - name: Install Secret GoogleService-Info.plist | ||
| # run: | | ||
| # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| # FirebaseMessaging/Apps/Shared/GoogleService-Info.plist "$plist_secret" | ||
| # - name: Prereqs | ||
| # run: scripts/install_prereqs.sh SwiftUISample iOS | ||
| # - name: Xcode | ||
| # run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| # - name: Build | ||
| # run: ([ -z $plist_secret ] || scripts/build.sh SwiftUISample iOS) | ||
|
|
||
| messaging-watchos-standalone-sample-build-test: | ||
| # Don't run on private repo unless it is a PR. | ||
| if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| env: | ||
| plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| runs-on: macos-15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| with: | ||
| cache_key: watch-sample${{ matrix.os }} | ||
| - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| - name: Setup Bundler | ||
| run: scripts/setup_bundler.sh | ||
| - name: Install Secret GoogleService-Info.plist | ||
| run: | | ||
| scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| FirebaseMessaging/Apps/Shared/GoogleService-Info.plist "$plist_secret" | ||
| - name: Prereqs | ||
| run: scripts/install_prereqs.sh MessagingSampleStandaloneWatchApp watchOS | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Build | ||
| run: ([ -z $plist_secret ] || scripts/build.sh MessagingSampleStandaloneWatchApp watchOS) | ||
| - name: Upload xcodebuild logs | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: xcodebuild-logs-${{ matrix.target }} | ||
| path: xcodebuild-*.log | ||
| # messaging-watchos-standalone-sample-build-test: | ||
| # # Don't run on private repo unless it is a PR. | ||
| # if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request' | ||
| # env: | ||
| # plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
| # runs-on: macos-15 | ||
| # steps: | ||
| # - uses: actions/checkout@v4 | ||
| # - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126 | ||
| # with: | ||
| # cache_key: watch-sample${{ matrix.os }} | ||
| # - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1 | ||
| # - name: Setup Bundler | ||
| # run: scripts/setup_bundler.sh | ||
| # - name: Install Secret GoogleService-Info.plist | ||
| # run: | | ||
| # scripts/decrypt_gha_secret.sh scripts/gha-encrypted/messaging-sample-plist.gpg \ | ||
| # FirebaseMessaging/Apps/Shared/GoogleService-Info.plist "$plist_secret" | ||
| # - name: Prereqs | ||
| # run: scripts/install_prereqs.sh MessagingSampleStandaloneWatchApp watchOS | ||
| # - name: Xcode | ||
| # run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| # - name: Build | ||
| # run: ([ -z $plist_secret ] || scripts/build.sh MessagingSampleStandaloneWatchApp watchOS) | ||
| # - name: Upload xcodebuild logs | ||
| # if: failure() | ||
| # uses: actions/upload-artifact@v4 | ||
| # with: | ||
| # name: xcodebuild-logs-${{ matrix.target }} | ||
| # path: xcodebuild-*.log | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.