Skip to content

Conversation

@cherylEnkidu
Copy link
Contributor

#no-changelog

@cherylEnkidu cherylEnkidu requested a review from a team as a code owner January 7, 2026 18:43
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to test both backend and non-backend?

@cherylEnkidu
Copy link
Contributor Author

Do we want to test both backend and non-backend?

Yes, I am checking here to see whether the environment variable works. Ideally the test set should be like:

  1. TARGET_BACKEND = nightly BACKEND_EDITION = standard
  2. TARGET_BACKEND = nightly BACKEND_EDITION = enterprise
  3. TARGET_BACKEND = emulator BACKEND_EDITION = standard
  4. TARGET_BACKEND = emulator BACKEND_EDITION = enterprise

run: |
scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${{ matrix.target }} xcodebuild
xcodebuild_enterprise:
Copy link
Member

@ncooke3 ncooke3 Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consolidate this workflow with the above one by extending the above one's matrix.

The process would look like:

  1. Delete this new job.
  2. Above on line 366. Add to the matrix: scheme: [Firestore, FirestoreEnterprise] so it looks like:
     strategy:
       matrix:
         target: [iOS, macOS, tvOS]
         scheme: [Firestore, FirestoreEnterprise] <-- NEW line 366
  3. Then update script invocation:
- scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${{ matrix.target }} xcodebuild
+ scripts/third_party/travis/retry.sh scripts/build.sh ${{ matrix.scheme }} ${{ matrix.target }} xcodebuild

So one workflow job would test both schemes for each target (6 cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants