Skip to content

fix: Move reusable SPM and CocoaPods workflows to use Xcode 26.2 #15756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 4 commits into from
Jan 26, 2026
Merged

fix: Move reusable SPM and CocoaPods workflows to use Xcode 26.2 #15756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
382522a
Move to Xcode 26.2
ncooke3 Jan 23, 2026
ec59e19
Fix 'weak variable never mutated' warnings for Xcode 16.2+
ncooke3 Jan 23, 2026
09bf802
[skip ci] add changelog entry
ncooke3 Jan 26, 2026
4c97b9e
test
ncooke3 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/_cocoapods.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,11 @@ jobs:
fail-fast: false
matrix:
os: [macos-15, macos-26]
xcode: [Xcode_16.4, Xcode_26.1]
xcode: [Xcode_16.4, Xcode_26.2]
platform: [iOS, tvOS, macOS, watchOS]
exclude:
- os: macos-15
xcode: Xcode_26.1
xcode: Xcode_26.2
- os: macos-26
xcode: Xcode_16.4
include:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/_spm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ jobs:
fail-fast: false
matrix:
os: [macos-15, macos-26]
xcode: [Xcode_16.4, Xcode_26.1]
xcode: [Xcode_16.4, Xcode_26.2]
platform: [iOS, tvOS, macOS, watchOS, catalyst, visionOS]
exclude:
- os: macos-15
xcode: Xcode_26.1
xcode: Xcode_26.2
- os: macos-26
xcode: Xcode_16.4
include:
Expand Down
6 changes: 5 additions & 1 deletion FirebaseCore/Internal/Tests/Unit/HeartbeatStorageTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ class HeartbeatStorageTests: XCTestCase {
func testCachedInstancesCannotBeRetainedWeakly() {
// Given
var strongHeartbeatStorage: HeartbeatStorage? = .getInstance(id: "sparky")
weak var weakHeartbeatStorage: HeartbeatStorage? = .getInstance(id: "sparky")
#if swift(>=6.2)
weak let weakHeartbeatStorage: HeartbeatStorage? = .getInstance(id: "sparky")
#else
weak var weakHeartbeatStorage: HeartbeatStorage? = .getInstance(id: "sparky")
#endif
XCTAssert(
strongHeartbeatStorage === weakHeartbeatStorage,
"Instances should reference the same object."
Expand Down
3 changes: 3 additions & 0 deletions FirebaseStorage/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unreleased
- [fixed] Fix "weak never mutated" build warning introduced in Xcode 26.2.

# 12.0.0
- [removed] **Breaking change**: Removed the following unused API,
`StorageMetadata.storageReference`.
Expand Down
6 changes: 5 additions & 1 deletion FirebaseStorage/Sources/StorageReference.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ import Foundation
var prefixes = [StorageReference]()
var items = [StorageReference]()

weak var weakSelf = self
#if swift(>=6.2)
weak let weakSelf = self
#else
weak var weakSelf = self
#endif

var paginatedCompletion: ((_: StorageListResult?, _: Error?) -> Void)?
paginatedCompletion = { (_ listResult: StorageListResult?, _ error: Error?) in
Expand Down
Loading