feat: add new reusable workflow, _build.yml#15762
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
45e7793 was green. |
|
global tap had two unrelated flakes a6ab2b7 |
|
Looks like the Storage integration tests are NOT running https://github.com/firebase/firebase-ios-sdk/actions/runs/21367091022/job/61501729416 |
@paulb777, great catch! That's not good. I think it's related to my check_secrets.sh changes. Converting to draft. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new reusable workflow _build.yml and refactors the logic for checking secrets availability in CI environments. The new logic in check_secrets.sh is a significant improvement, making the process more explicit and robust, especially for handling builds from forks. I've added one minor suggestion to simplify the conditional logic for improved readability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a more robust mechanism for checking secret availability in CI within scripts/check_secrets.sh. The changes prioritize new, explicit environment variables while retaining backward compatibility for older workflows, which is a solid approach for managing CI configurations, especially with forks. The code is well-commented and the logic is sound. I have a couple of minor suggestions to make the shell script syntax slightly more concise.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
|
There was a problem hiding this comment.
Code Review
This pull request introduces a more robust mechanism for checking the availability of secrets in the CI environment, which is particularly useful for handling builds from forked repositories. The changes in scripts/check_secrets.sh prioritize new, explicit environment variables for this check, while maintaining backward compatibility for older workflows. This is a solid improvement for CI reliability. I have one minor suggestion to enhance the readability of the new logic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
laike9m
left a comment
There was a problem hiding this comment.
This is a great initiative to consolidate the build logic into a reusable workflow. It significantly reduces duplication and improves maintainability.
I've identified a few issues, most notably a potential bug in the repository name comparison due to case sensitivity in bash, and some opportunities for optimization regarding simulator downloads and build retries.
- Make repository check case-insensitive in _build.yml - Add max_attempts input to _build.yml - Remove redundant if conditions in sdk.database.yml and sdk.mlmodeldownloader.yml
Add new reusable workflow that wraps the scripts/build.sh script and provides consolidated Xcode selection, simulator installation and log uploading.
Fix #15770
#no-changelog