Skip to content

Comments

chore(ci): adress workflow linting warnings#15816

Merged
ncooke3 merged 7 commits intomainfrom
nc/address-lints
Feb 17, 2026
Merged

chore(ci): adress workflow linting warnings#15816
ncooke3 merged 7 commits intomainfrom
nc/address-lints

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Feb 17, 2026

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@ncooke3
Copy link
Member Author

ncooke3 commented Feb 17, 2026

/gemini review

@ncooke3 ncooke3 changed the title chore(ci): modernize workflows, fix lints, and harden security chore(ci): adress workflow linting warnings Feb 17, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively modernizes the workflow by using environment variables for inputs, which is a great security hardening practice. I've added one suggestion to further improve the maintainability of the script by reducing code duplication.

@ncooke3
Copy link
Member Author

ncooke3 commented Feb 17, 2026

Failures are flakes/expected.

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two requested edits.

@ncooke3 ncooke3 marked this pull request as ready for review February 17, 2026 22:58
@ncooke3 ncooke3 requested a review from a team as a code owner February 17, 2026 22:58
@ncooke3 ncooke3 merged commit c8957aa into main Feb 17, 2026
535 of 539 checks passed
@ncooke3 ncooke3 deleted the nc/address-lints branch February 17, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants