Skip to content

Comments

[AI] Few more generable structured output tests#15873

Open
paulb777 wants to merge 3 commits intoah/ai-generative-model-sessionfrom
pb-more-structured-output-generable-tests
Open

[AI] Few more generable structured output tests#15873
paulb777 wants to merge 3 commits intoah/ai-generative-model-sessionfrom
pb-more-structured-output-generable-tests

Conversation

@paulb777
Copy link
Member

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@paulb777 paulb777 force-pushed the pb-more-structured-output-generable-tests branch from c24d550 to 33c057f Compare February 20, 2026 23:54
@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds more integration tests for structured output generation using @Generable. The new tests cover generating a single complex object (Recipe) and a list of objects (RecipeList). The changes are good and increase test coverage. I have a couple of minor suggestions to improve the assertions in the new tests for better readability and completeness.

@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds comprehensive integration tests for structured output using the @Generable macro. It covers various data types including enums, nested structs, and arrays. I've suggested a minor improvement to the respondGenerableRecipeList test to include assertions for the rating property, ensuring consistency across tests and verifying that the model respects all defined constraints.

@paulb777 paulb777 marked this pull request as ready for review February 21, 2026 00:27
@paulb777 paulb777 requested a review from andrewheard February 21, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant