Removed console.logs

Author: maneesht

.github/workflows/test-all.yml

@@ -92,7 +92,7 @@ jobs:
     - name: Run unit tests
       # Ignore auth data-connect and firestore since they're handled in their own separate jobs.
       run: |
-        xvfb-run yarn lerna run --ignore '{firebase-messaging-integration-test,@firebase/auth*,@firebase/data-connect*,@firebase/firestore*,firebase-firestore-integration-test}' test:ci
+        xvfb-run yarn lerna run --ignore '{firebase-messaging-integration-test,@firebase/auth*,@firebase/firestore*,firebase-firestore-integration-test}' test:ci
         node scripts/print_test_logs.js
       env:
         FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}

.github/workflows/test-changed-data-connect.yml

@@ -18,9 +18,11 @@
 import { deleteApp, initializeApp } from '@firebase/app';
 import { expect } from 'chai';
 
-import { ConnectorConfig, getDataConnect } from '../../src';
+import { getDataConnect } from '../../src';
 
 describe('Data Connect Test', () => {
+  beforeEach(() => {
+  });
   it('should throw an error if `projectId` is not provided', async () => {
     const app = initializeApp({ projectId: undefined }, 'a');
     expect(() =>
@@ -30,24 +32,27 @@ describe('Data Connect Test', () => {
     );
     await deleteApp(app);
   });
-  it('should not throw an error if `projectId` is provided', () => {
+  it('should not throw an error if `projectId` is provided', async () => {
     const projectId = 'p';
-    initializeApp({ projectId });
+    const customApp = initializeApp({ projectId }, 'customApp');
     expect(() =>
       getDataConnect({ connector: 'c', location: 'l', service: 's' })
     ).to.not.throw(
       'Project ID must be provided. Did you pass in a proper projectId to initializeApp?'
     );
-    const dc = getDataConnect({ connector: 'c', location: 'l', service: 's' });
+    const dc = getDataConnect(customApp, { connector: 'c', location: 'l', service: 's' });
     expect(dc.app.options.projectId).to.eq(projectId);
+    await deleteApp(customApp);
   });
-  it('should throw an error if `connectorConfig` is not provided', () => {
+  it('should throw an error if `connectorConfig` is not provided', async () => {
     const projectId = 'p';
-    initializeApp({ projectId });
-    expect(() => getDataConnect({} as ConnectorConfig)).to.throw(
+    const customApp = initializeApp({ projectId }, 'customApp');
+    // @ts-ignore
+    expect(() => getDataConnect(customApp)).to.throw(
       'DC Option Required'
     );
-    const dc = getDataConnect({ connector: 'c', location: 'l', service: 's' });
+    const dc = getDataConnect(customApp, { connector: 'c', location: 'l', service: 's' });
     expect(dc.app.options.projectId).to.eq(projectId);
+    await deleteApp(customApp);
   });
 });

packages/data-connect/test/unit/dataconnect.test.ts

@@ -15,19 +15,12 @@
  * limitations under the License.
  */
 
-import { deleteApp, FirebaseApp, initializeApp } from '@firebase/app';
 import { expect } from 'chai';
 
 import { getDataConnect } from '../../src';
 import { validateArgs } from '../../src/util/validateArgs';
+import { app } from '../util';
 describe('Utils', () => {
-  let defaultApp: FirebaseApp;
-  beforeEach(() => {
-    defaultApp = initializeApp({ projectId: 'p' });
-  });
-  afterEach(async () => {
-    await deleteApp(defaultApp);
-  });
   it('[Vars required: true] should throw if no arguments are provided', () => {
     const connectorConfig = { connector: 'c', location: 'l', service: 's' };
     expect(() =>
@@ -36,20 +29,20 @@ describe('Utils', () => {
   });
   it('[vars required: false, vars provided: false] should return data connect instance and no variables', () => {
     const connectorConfig = { connector: 'c', location: 'l', service: 's' };
-    const dc = getDataConnect(connectorConfig);
+    const dc = getDataConnect(app, connectorConfig);
     expect(validateArgs(connectorConfig)).to.deep.eq({ dc, vars: undefined });
   });
   it('[vars required: false, vars provided: false, data connect provided: true] should return data connect instance and no variables', () => {
     const connectorConfig = { connector: 'c', location: 'l', service: 's' };
-    const dc = getDataConnect(connectorConfig);
+    const dc = getDataConnect(app, connectorConfig);
     expect(validateArgs(connectorConfig, dc)).to.deep.eq({
       dc,
       vars: undefined
     });
   });
   it('[vars required: true, vars provided: true, data connect provided: true] should return data connect instance and variables', () => {
     const connectorConfig = { connector: 'c', location: 'l', service: 's' };
-    const dc = getDataConnect(connectorConfig);
+    const dc = getDataConnect(app, connectorConfig);
     const vars = { a: 1 };
     expect(validateArgs(connectorConfig, dc, vars)).to.deep.eq({ dc, vars });
   });

packages/data-connect/test/unit/utils.test.ts

@@ -26,7 +26,6 @@ import {
 
 export const EMULATOR_PORT = process.env.DC_EMULATOR_PORT;
 // eslint-disable-next-line no-console
-console.log('Emulator Port: ' + EMULATOR_PORT);
 const USE_EMULATOR = !!EMULATOR_PORT;
 export const CONNECTOR_NAME = 'tests';
 export const LOCATION_NAME = 'us-west2';
@@ -49,9 +48,6 @@ export function initDatabase(): DataConnect {
   const instance = getDataConnect(getConnectionConfig());
   if (USE_EMULATOR) {
     connectDataConnectEmulator(instance, 'localhost', Number(EMULATOR_PORT));
-  } else {
-    // eslint-disable-next-line no-console
-    console.log('not running emulator');
   }
   return instance;
 }

packages/data-connect/test/util.ts

@@ -76,8 +76,5 @@ export const testConfig: {
   },
   'auth': {
     'onlyIncludePackages': ['@firebase/auth', '@firebase/auth-compat']
-  },
-  'data-connect': {
-    'onlyIncludePackages': ['@firebase/data-connect']
   }
 };