Implement SessionToken Persistence #8388

tom-andersen · 2024-07-24T14:47:57Z

Persistence of SessionToken

changeset-bot · 2024-07-24T14:48:01Z

⚠️ No Changeset found

Latest commit: 10f27be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

* added authStateReady function * updated Auth interface * added unit tests on authStateReady * updated demo app * added authStateReady to Auth interface * fixed formatting issue * updated authStateReady calls in demo app * fixed formatting issues * fixed demo app to incorporate authStateReady * formatted code * removed unnecessary async keywords * reverted changes in onSignOut * clean up code * fixed comments * resolved code review comments and updated tests * changed reference doc * resolved comments from pr * added changeset * Update twelve-actors-enjoy.md * resolved doc change check failure * resolved issues with Doc Change Check * clarify comments * fixed doc change check issue

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…of a WriteBatch

…#7501)

…7504) Example error - https://github.com/firebase/firebase-js-sdk/actions/runs/5693107410/job/15431784566?pr=7501 "No such object: chromedriver/LATEST_RELEASE_115.0.5790"

Expose PrivateSettings interface as an internal type for the Firestore console. It was exported in the previous version of the non-modular firestore SDK we used in console.

…message in deep equals (#7519) * equality_matcher.ts: fix absence of custom message in assertion failure messages * equality_matcher.ts: remove usage of the now-deleted `msg` argument * equality_matcher.ts: fix type of `originalFunction`

Fix aggregate query order-by normalization to support future aggregate operations.

…uth (#7514) * Implement validatePassword endpoint for public API with PasswordPolicy and PasswordValidationStatus public types * Update auth demo to include a section for password validation

* Update proto loader * Update proto loader * Update proto loader * Update proto loader

Review and update of the CONTRIBUTING.md guide.

* Fix and skip flaky tests * add todos * more nits

* Fix auth event uncancellable bug * add changeset file * includes issue number on changesets * yarn format

* Use safevalues to fix trusted types issues reported by tsec * Upgrade to safevalues 0.6.0 * Remove exemptions, and untested usages of safevalues * Add dependency that was accidentally removed * Add FIXMEs for tsec violations * Run formatting * Compare against full Gtag script in tests * Check that full reCAPTCHA script URL was assigned to script element * Replace FIXMEs with TODOs * Remove auth, rtdb, messaging from changeset

)

Numerous fixes to spelling across the SDK.

Fixed the format of a changeset file. I had hand edited a changeset in a previous PR and accidentally stripped out the "release notes" section.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

google-oss-bot · 2024-07-24T15:04:40Z

Size Report ¹

Affected Products

`@firebase/firestore`

Type	Base (`46da093`)	Merge (`10a3ef2`)	Diff
browser	378 kB	379 kB	+896 B (+0.2%)
esm5	363 kB	364 kB	+932 B (+0.3%)
main	582 kB	583 kB	+1.25 kB (+0.2%)
module	378 kB	379 kB	+896 B (+0.2%)
react-native	378 kB	379 kB	+896 B (+0.2%)

`bundle`

Type	Base (`46da093`)	Merge (`10a3ef2`)	Diff
firestore (CSI Auto Indexing Disable and Delete)	268 kB	269 kB	+687 B (+0.3%)
firestore (CSI Auto Indexing Enable)	268 kB	269 kB	+687 B (+0.3%)
firestore (Persistence)	303 kB	304 kB	+687 B (+0.2%)
firestore (Query Cursors)	240 kB	240 kB	+228 B (+0.1%)
firestore (Query)	238 kB	238 kB	+228 B (+0.1%)
firestore (Read data once)	226 kB	226 kB	+228 B (+0.1%)
firestore (Read Write w Persistence)	323 kB	323 kB	+687 B (+0.2%)
firestore (Realtime updates)	228 kB	228 kB	+228 B (+0.1%)
firestore (Transaction)	205 kB	205 kB	+228 B (+0.1%)
firestore (Write data)	205 kB	205 kB	+228 B (+0.1%)

firebase
Type Base (46da093) Merge (10a3ef2) Diff
firebase-compat.js 789 kB 790 kB +662 B (+0.1%)
firebase-firestore-compat.js 341 kB 342 kB +662 B (+0.2%)
firebase-firestore.js 437 kB 438 kB +896 B (+0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/hN4mUx90vr.html

google-oss-bot · 2024-07-24T15:15:45Z

Size Analysis Report ¹

This report is too large (308,771 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/3KUBouTkiP.html

tom-andersen marked this pull request as ready for review July 24, 2024 14:48

tom-andersen requested review from a team as code owners July 24, 2024 14:48

tom-andersen requested a review from wu-hui July 24, 2024 14:49

tom-andersen assigned wu-hui Jul 24, 2024

hsubox76 and others added 24 commits July 24, 2024 10:55

Bump firebase (#7477)

f2c1828

Various bloom filter logic cleanup ported from Android (#7474)

bd24be9

Version Packages (#7478)

a303bd3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Firestore: query.test.ts: use a different Firestore instance instead …

bb48b9f

…of a WriteBatch

Run E2E tests on canary releases #7475

1796149

Increase GHA artifact retention from 2 to 14 days (#7495)

0fb42ee

Firestore: query_engine.test.ts: fix logic that checks configureCsi (…

70be2fe

…#7501)

Pin the webdriver version in Firefox test to avoid install failures. (#…

eef4ff1

…7504) Example error - https://github.com/firebase/firebase-js-sdk/actions/runs/5693107410/job/15431784566?pr=7501 "No such object: chromedriver/LATEST_RELEASE_115.0.5790"

Export internal interface PrivateSettings for console (#7492)

f1c850f

Expose PrivateSettings interface as an internal type for the Firestore console. It was exported in the previous version of the non-modular firestore SDK we used in console.

Fix: Aggregate query order-by normalization (#7507)

cd69f6b

Fix aggregate query order-by normalization to support future aggregate operations.

Separate the implementation of initializeRecaptchaConfig (#7515)

f8163bd

Setup firestore tests for named db (#7505)

2ae4353

Add support for validating passwords against the password policy in a…

1b87196

…uth (#7514) * Implement validatePassword endpoint for public API with PasswordPolicy and PasswordValidationStatus public types * Update auth demo to include a section for password validation

fix: Update proto loader (#7520)

820ecce

* Update proto loader * Update proto loader * Update proto loader * Update proto loader

Raise error if calling initializeRecaptchaConfig in node env (#7284)

9302a2d

Skip large sized bloom filter golden tests (#7537)

74c529b

Updates to our contributing guidance (#7526)

1860fb4

Review and update of the CONTRIBUTING.md guide.

Fix and skip flaky Firestore tests (#7552)

3466bba

* Fix and skip flaky tests * add todos * more nits

Upgrade webpack to v5 (#7540)

ce1ef52

[Auth] Fix auth event uncancellable bug (#7498)

34c8666

* Fix auth event uncancellable bug * add changeset file * includes issue number on changesets * yarn format

Fix changeset checker to write to github output correctly (#7554)

ecfc80c

Update CODEOWNERS (#7562)

a508051

tanzimfh and others added 8 commits July 24, 2024 10:55

VertexAI: add support for mock responses versioning system (#8361)

5676813

Disable extraneous import errors on violating lines in auth tests (#8363

6d7dc17

)

Spelling (#8280)

0f96114

Numerous fixes to spelling across the SDK.

Fix format of a changeset file

ec39c8f

Fixed the format of a changeset file. I had hand edited a changeset in a previous PR and accidentally stripped out the "release notes" section.

Version Packages (#8369)

d03815f

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Implement SessionToken Persistence

13622ea

Pretty

c559e03

tom-andersen force-pushed the tomandersen/sessionPersistence branch from ef12eed to c559e03 Compare July 24, 2024 14:56

tom-andersen requested review from a team, hsubox76, erikeldridge, jposuna, avolkovi, yoyomyo, sam-gc, yuchenshi, lisajian, Xiaoshouzi-gh, zwu52, maneesht, tonyjhuang and aashishpatil-g as code owners July 24, 2024 14:56

Implement SessionToken Persistence

10f27be

tom-andersen closed this Jul 24, 2024

tom-andersen deleted the tomandersen/sessionPersistence branch July 24, 2024 15:42

firebase locked and limited conversation to collaborators Aug 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement SessionToken Persistence #8388

Implement SessionToken Persistence #8388

Uh oh!

tom-andersen commented Jul 24, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 24, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 24, 2024 •

edited

Loading

`@firebase/firestore`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented Jul 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

Implement SessionToken Persistence #8388

Implement SessionToken Persistence #8388

Uh oh!

Conversation

tom-andersen commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Test Logs

Uh oh!

Uh oh!

tom-andersen commented Jul 24, 2024 •

edited

Loading

changeset-bot bot commented Jul 24, 2024 •

edited

Loading

google-oss-bot commented Jul 24, 2024 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`bundle`

`firebase`

google-oss-bot commented Jul 24, 2024 •

edited

Loading

Size Analysis Report ¹