Tomandersen/session token persistence #8390

tom-andersen · 2024-07-24T15:44:58Z

Persistence of SessionToken

* added authStateReady function * updated Auth interface * added unit tests on authStateReady * updated demo app * added authStateReady to Auth interface * fixed formatting issue * updated authStateReady calls in demo app * fixed formatting issues * fixed demo app to incorporate authStateReady * formatted code * removed unnecessary async keywords * reverted changes in onSignOut * clean up code * fixed comments * resolved code review comments and updated tests * changed reference doc * resolved comments from pr * added changeset * Update twelve-actors-enjoy.md * resolved doc change check failure * resolved issues with Doc Change Check * clarify comments * fixed doc change check issue

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…of a WriteBatch

…#7501)

…7504) Example error - https://github.com/firebase/firebase-js-sdk/actions/runs/5693107410/job/15431784566?pr=7501 "No such object: chromedriver/LATEST_RELEASE_115.0.5790"

Expose PrivateSettings interface as an internal type for the Firestore console. It was exported in the previous version of the non-modular firestore SDK we used in console.

…message in deep equals (#7519) * equality_matcher.ts: fix absence of custom message in assertion failure messages * equality_matcher.ts: remove usage of the now-deleted `msg` argument * equality_matcher.ts: fix type of `originalFunction`

Fix aggregate query order-by normalization to support future aggregate operations.

…uth (#7514) * Implement validatePassword endpoint for public API with PasswordPolicy and PasswordValidationStatus public types * Update auth demo to include a section for password validation

* Update proto loader * Update proto loader * Update proto loader * Update proto loader

Review and update of the CONTRIBUTING.md guide.

* Fix and skip flaky tests * add todos * more nits

* Fix auth event uncancellable bug * add changeset file * includes issue number on changesets * yarn format

#7543)

* fix: Fix a typo in the webchannel-wrapper's package.json. * Create orange-rings-own.md

)

* Update sync_engine_impl.ts * add spec test * update comment * typo * update spec test * add changeset

Update browser detection logic: Detect either window or web worker (WorkerGlobalScope). This updates the implementation to `isBrowser()` and adds a new function `isWebWorker()`. Fixes #8299 #8284

… availability. (#8335) There was code that would errantly attempt to allocate a FinalizationRegstiry in FirebaseServerAppImpl regardless of the existence of releaseOnDeref field, and this caused issues in some edge environments. This change fixes that issue.

The custom domain "firebase-sdk-health-metrics.com" currently associated with the Metric Service will be deprecated eventually, due to the acquisition of Google Domains by Squarespace. Switching to the original URL created by Google Cloud Run (which hosts the Metric Service) to avoid service disruption. See b/303931111 for more details.

) This change fixes a TypeScript compilation error. The `FirebaseServerAppSettings.name` field inherited from `FirebaseAppSettings` but the type was redefined from `string` to `undefined`. This redefinition would cause a TypeScript compliation error if `exactOptionalPropertyTypes` was set `true` in `packages/app/tsconfig.json`. This change now uses `omit< , >` to strip the `name` field from the `FirebaseServerAppSettings` declaration, where `FirebaseAppSettings` is extended. Fixes #8336

…ponses (#8342)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ng yarn lock (#8298) * Upgrade google-cloud-firestore in rules-unit-testing yarn lock The version of google-cloud-firestore in the rules-unit-testing yarn.lock was listed as 6.6.0, when it was actually 6.8.0. This change ugrades the listed version to be the real version. * Add changeset

* Use safevalues to fix trusted types issues reported by tsec * Upgrade to safevalues 0.6.0 * Remove exemptions, and untested usages of safevalues * Add dependency that was accidentally removed * Add FIXMEs for tsec violations * Run formatting * Compare against full Gtag script in tests * Check that full reCAPTCHA script URL was assigned to script element * Replace FIXMEs with TODOs * Remove auth, rtdb, messaging from changeset

)

Numerous fixes to spelling across the SDK.

Fixed the format of a changeset file. I had hand edited a changeset in a previous PR and accidentally stripped out the "release notes" section.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

changeset-bot · 2024-07-24T15:45:02Z

⚠️ No Changeset found

Latest commit: da9d2de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2024-07-24T16:00:34Z

Size Report ¹

Affected Products

`@firebase/firestore`

Type	Base (`46da093`)	Merge (`7af0691`)	Diff
browser	378 kB	379 kB	+896 B (+0.2%)
esm5	363 kB	364 kB	+932 B (+0.3%)
main	582 kB	583 kB	+1.25 kB (+0.2%)
module	378 kB	379 kB	+896 B (+0.2%)
react-native	378 kB	379 kB	+896 B (+0.2%)

`bundle`

Type	Base (`46da093`)	Merge (`7af0691`)	Diff
firestore (CSI Auto Indexing Disable and Delete)	268 kB	269 kB	+687 B (+0.3%)
firestore (CSI Auto Indexing Enable)	268 kB	269 kB	+687 B (+0.3%)
firestore (Persistence)	303 kB	304 kB	+687 B (+0.2%)
firestore (Query Cursors)	240 kB	240 kB	+228 B (+0.1%)
firestore (Query)	238 kB	238 kB	+228 B (+0.1%)
firestore (Read data once)	226 kB	226 kB	+228 B (+0.1%)
firestore (Read Write w Persistence)	323 kB	323 kB	+687 B (+0.2%)
firestore (Realtime updates)	228 kB	228 kB	+228 B (+0.1%)
firestore (Transaction)	205 kB	205 kB	+228 B (+0.1%)
firestore (Write data)	205 kB	205 kB	+228 B (+0.1%)

firebase
Type Base (46da093) Merge (7af0691) Diff
firebase-compat.js 789 kB 790 kB +662 B (+0.1%)
firebase-firestore-compat.js 341 kB 342 kB +662 B (+0.2%)
firebase-firestore.js 437 kB 438 kB +896 B (+0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/q99fcVEInj.html

google-oss-bot · 2024-07-24T16:11:31Z

Size Analysis Report ¹

This report is too large (308,771 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/I8oMMv3Xtx.html

hsubox76 and others added 30 commits July 24, 2024 10:55

Unpin version for React Native async storage dependency (#7467)

226c02e

Bump firebase (#7477)

f2c1828

Various bloom filter logic cleanup ported from Android (#7474)

bd24be9

Version Packages (#7478)

a303bd3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Firestore: query.test.ts: use a different Firestore instance instead …

bb48b9f

…of a WriteBatch

Run E2E tests on canary releases #7475

1796149

Increase GHA artifact retention from 2 to 14 days (#7495)

0fb42ee

Firestore: query_engine.test.ts: fix logic that checks configureCsi (…

70be2fe

…#7501)

Pin the webdriver version in Firefox test to avoid install failures. (#…

eef4ff1

…7504) Example error - https://github.com/firebase/firebase-js-sdk/actions/runs/5693107410/job/15431784566?pr=7501 "No such object: chromedriver/LATEST_RELEASE_115.0.5790"

Export internal interface PrivateSettings for console (#7492)

f1c850f

Expose PrivateSettings interface as an internal type for the Firestore console. It was exported in the previous version of the non-modular firestore SDK we used in console.

Fix: Aggregate query order-by normalization (#7507)

cd69f6b

Fix aggregate query order-by normalization to support future aggregate operations.

Separate the implementation of initializeRecaptchaConfig (#7515)

f8163bd

Setup firestore tests for named db (#7505)

2ae4353

Add support for validating passwords against the password policy in a…

1b87196

…uth (#7514) * Implement validatePassword endpoint for public API with PasswordPolicy and PasswordValidationStatus public types * Update auth demo to include a section for password validation

fix: Update proto loader (#7520)

820ecce

* Update proto loader * Update proto loader * Update proto loader * Update proto loader

Raise error if calling initializeRecaptchaConfig in node env (#7284)

9302a2d

Skip large sized bloom filter golden tests (#7537)

74c529b

Updates to our contributing guidance (#7526)

1860fb4

Review and update of the CONTRIBUTING.md guide.

Fix and skip flaky Firestore tests (#7552)

3466bba

* Fix and skip flaky tests * add todos * more nits

Upgrade webpack to v5 (#7540)

ce1ef52

[Auth] Fix auth event uncancellable bug (#7498)

34c8666

* Fix auth event uncancellable bug * add changeset file * includes issue number on changesets * yarn format

Fix changeset checker to write to github output correctly (#7554)

ecfc80c

Update CODEOWNERS (#7562)

a508051

Setup separate GA jobs for firestore (#7523)

4064331

Firestore: testing_hooks.ts: move some logic into testing_hooks_spi.ts (

76a7f1f

#7543)

Fix webpack env variable settings (#7557)

16ebdff

Include full output from mocha/karma in CI (#7567)

80f3c68

Run 'Firestore Integration Tests' jobs in parallel (#7558)

63d2c13

hsubox76 and others added 23 commits July 24, 2024 10:55

remove some unused NPM token env variables (#8330)

90999a8

fix: Fix a typo in the webchannel-wrapper's package.json. (#8331)

9c18bf8

* fix: Fix a typo in the webchannel-wrapper's package.json. * Create orange-rings-own.md

Add a new VertexAI error type (#8240)

a0875c5

VertexAI: update testing to clone mock responses from shared repo (#8333

d703548

)

Fix multi-tab snapshot listener metadata sync issue (#8339)

61fcec3

* Update sync_engine_impl.ts * add spec test * update comment * typo * update spec test * add changeset

fix: browser detection (#8315)

ca1e4dd

Update browser detection logic: Detect either window or web worker (WorkerGlobalScope). This updates the implementation to `isBrowser()` and adds a new function `isWebWorker()`. Fixes #8299 #8284

VertexAI: add test script to run unit tests without updating mock res…

0b70923

…ponses (#8342)

Fix typos in VertexAI errors docs (#8346)

cd39256

Version Packages (#8345)

0205e0a

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Upgrade setup-gcloud to v2 (#8286)

e2aa0e9

Remove .git (#8362)

04fa109

VertexAI: add support for mock responses versioning system (#8361)

5676813

Disable extraneous import errors on violating lines in auth tests (#8363

6d7dc17

)

Spelling (#8280)

0f96114

Numerous fixes to spelling across the SDK.

Fix format of a changeset file

ec39c8f

Fixed the format of a changeset file. I had hand edited a changeset in a previous PR and accidentally stripped out the "release notes" section.

Version Packages (#8369)

d03815f

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk

8abba67

Implement SessionToken Persistence

da9d2de

tom-andersen requested review from a team as code owners July 24, 2024 15:44

tom-andersen closed this Jul 24, 2024

firebase locked and limited conversation to collaborators Aug 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tomandersen/session token persistence #8390

Tomandersen/session token persistence #8390

Uh oh!

tom-andersen commented Jul 24, 2024

Uh oh!

changeset-bot bot commented Jul 24, 2024

Uh oh!

google-oss-bot commented Jul 24, 2024

`@firebase/firestore`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented Jul 24, 2024

Uh oh!

Uh oh!

Tomandersen/session token persistence #8390

Tomandersen/session token persistence #8390

Uh oh!

Conversation

tom-andersen commented Jul 24, 2024

Uh oh!

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Jul 24, 2024

Size Report 1

Affected Products

@firebase/firestore

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 24, 2024

Size Analysis Report 1

Test Logs

Uh oh!

Uh oh!

Size Report ¹

`@firebase/firestore`

`bundle`

`firebase`

Size Analysis Report ¹