Skip to content

Close emulator file after download is complete #8572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Close emulator file after download is complete #8572

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a755c5
close file
dlarocque Oct 15, 2024
069ed52
Add test:ci to end of test command in CI
dlarocque Oct 15, 2024
64223d1
revert workflow file changes
dlarocque Oct 15, 2024
720a9e5
format
dlarocque Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions scripts/emulator-testing/emulators/emulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,17 @@ export abstract class Emulator {
const reader = resp.body.getReader();
reader.read().then(function readChunk({ done, value }): any {
if (done) {
downloadComplete();
console.log('Emulator download is done.');
writer.close(err => {
if (err) {
downloadFailed(
`Failed to close the downloaded emulator file: ${err}`
);
}

console.log('Closed downloaded emulator file.');
downloadComplete();
});
} else {
writer.write(value);
return reader.read().then(readChunk);
Expand All @@ -92,7 +102,6 @@ export abstract class Emulator {

downloadPromise.then(
() => {
console.log('Download complete');
// Change emulator binary file permission to 'rwxr-xr-x'.
// The execute permission is required for it to be able to start
// with 'java -jar'.
Expand Down
Loading