Skip to content

Remove unused convertPropertiesForEnclosingClass #8618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Remove unused convertPropertiesForEnclosingClass #8618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions repo-scripts/prune-dts/prune-dts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,61 +268,6 @@ function prunePrivateImports<
}
}

/**
* Iterates over the provided symbols and returns named declarations for these
* symbols if they are missing from `currentClass`. This allows us to merge
* class hierarchies for classes whose inherited types are not part of the
* public API.
*
* This method relies on a private API in TypeScript's `codefix` package.
*/
function convertPropertiesForEnclosingClass(
program: ts.Program,
host: ts.CompilerHost,
sourceFile: ts.SourceFile,
parentClassSymbols: ts.Symbol[],
currentClass: ts.ClassDeclaration
): ts.ClassElement[] {
const newMembers: ts.ClassElement[] = [];
// The `codefix` package is not public but it does exactly what we want. It's
// the same package that is used by VSCode to fill in missing members, which
// is what we are using it for in this script. `codefix` handles missing
// properties, methods and correctly deduces generics.
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(ts as any).codefix.createMissingMemberNodes(
currentClass,
parentClassSymbols,
sourceFile,
{ program, host },
/* userPreferences= */ {},
/* importAdder= */ undefined,
(missingMember: ts.ClassElement) => {
const originalSymbol = parentClassSymbols.find(
symbol =>
symbol.escapedName ==
(missingMember.name as ts.Identifier).escapedText
);
if (originalSymbol) {
const jsDocComment = extractJSDocComment(originalSymbol, newMembers);
if (jsDocComment) {
ts.setSyntheticLeadingComments(missingMember, [
{
kind: ts.SyntaxKind.MultiLineCommentTrivia,
text: `*\n${jsDocComment}\n`,
hasTrailingNewLine: true,
pos: -1,
end: -1
}
]);
}

newMembers.push(missingMember);
}
}
);
return newMembers;
}

/**
* Iterates over the provided symbols and returns named declarations for these
* symbols if they are missing from `currentInterface`. This allows us to merge
Expand Down
Loading