Skip to content

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: 39be53c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 1, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (caf3090)Merge (56501e7)Diff
    browser381 kB414 kB+32.9 kB (+8.6%)
    main588 kB646 kB+57.8 kB (+9.8%)
    module381 kB414 kB+32.9 kB (+8.6%)
    react-native382 kB415 kB+32.9 kB (+8.6%)
  • @firebase/firestore-lite

    TypeBase (caf3090)Merge (56501e7)Diff
    browser111 kB144 kB+32.5 kB (+29.2%)
    main153 kB207 kB+53.8 kB (+35.2%)
    module111 kB144 kB+32.5 kB (+29.2%)
    react-native111 kB144 kB+32.5 kB (+29.2%)
  • bundle

    16 size changes

    TypeBase (caf3090)Merge (56501e7)Diff
    firestore (CSI Auto Indexing Disable and Delete)272 kB272 kB+64 B (+0.0%)
    firestore (CSI Auto Indexing Enable)272 kB272 kB+64 B (+0.0%)
    firestore (Persistence)303 kB303 kB+64 B (+0.0%)
    firestore (Pipeline Query with lt filter)?126 kB? (?)
    firestore (Query Cursors)249 kB249 kB+521 B (+0.2%)
    firestore (Query)247 kB247 kB+521 B (+0.2%)
    firestore (Read data once)234 kB234 kB+34 B (+0.0%)
    firestore (Read Write w Persistence)328 kB329 kB+551 B (+0.2%)
    firestore (Realtime updates)237 kB237 kB+34 B (+0.0%)
    firestore (Transaction)214 kB214 kB+621 B (+0.3%)
    firestore (Write data)213 kB214 kB+521 B (+0.2%)
    firestore-lite (Query Cursors)91.4 kB91.9 kB+524 B (+0.6%)
    firestore-lite (Query)87.6 kB88.1 kB+524 B (+0.6%)
    firestore-lite (Read data once)63.0 kB63.1 kB+34 B (+0.1%)
    firestore-lite (Transaction)88.3 kB88.9 kB+624 B (+0.7%)
    firestore-lite (Write data)72.6 kB73.2 kB+524 B (+0.7%)

  • firebase

    TypeBase (caf3090)Merge (56501e7)Diff
    firebase-compat.js794 kB795 kB+696 B (+0.1%)
    firebase-firestore-compat.js346 kB347 kB+696 B (+0.2%)
    firebase-firestore-lite.js119 kB151 kB+32.4 kB (+27.3%)
    firebase-firestore.js440 kB473 kB+32.8 kB (+7.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iAYAv1n1mb.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 1, 2024

Size Analysis Report 1

This report is too large (1,040,869 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gOBxeeYi00.html

@firebase firebase locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants