Skip to content

Add a test for comparing cross type numbers #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add a test for comparing cross type numbers #8685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions packages/firestore/test/integration/api/query.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ import {
writeBatch,
CollectionReference,
WriteBatch,
Firestore
Firestore,
getDocsFromServer
} from '../util/firebase_export';
import {
apiDescribe,
Expand All @@ -66,7 +67,8 @@ import {
withRetry,
withTestCollection,
withTestDb,
checkOnlineAndOfflineResultsMatch
checkOnlineAndOfflineResultsMatch,
toIds
} from '../util/helpers';
import { USE_EMULATOR } from '../util/settings';
import { captureExistenceFilterMismatches } from '../util/testing_hooks_util';
Expand Down Expand Up @@ -2262,6 +2264,35 @@ apiDescribe('Queries', persistence => {
}
);
});

it('snapshot listener sorts cross type numbers same way as server', async () => {
const testDocs = {
'longMin': { value: '-9223372036854775808' },
'longMax': { value: '9223372036854775807' },
'NaN': { value: NaN },
'maxSafeInteger': { value: Number.MAX_SAFE_INTEGER },
'minSafeInteger': { value: Number.MIN_SAFE_INTEGER },
'maxValue': { value: Number.MAX_VALUE },
'negativeMaxValue': { value: -Number.MAX_VALUE },
'minValue': { value: Number.MIN_VALUE },
'negativeMinValue': { value: -Number.MIN_VALUE },
'negativeInfinity': { value: -Infinity },
'positiveInfinity': { value: Infinity }
};

return withTestCollection(persistence, testDocs, async collectionRef => {
const orderedQuery = query(collectionRef, orderBy('value'));

const getSnapshot = await getDocsFromServer(orderedQuery);

const storeEvent = new EventsAccumulator<QuerySnapshot>();
const unsubscribe = onSnapshot(orderedQuery, storeEvent.storeEvent);
const watchSnapshot = await storeEvent.awaitEvent();
expect(toIds(watchSnapshot)).to.deep.equal(toIds(getSnapshot));

unsubscribe();
});
});
});

apiDescribe('Hanging query issue - #7652', persistence => {
Expand Down
Loading