Skip to content

Conversation

DellaBitta
Copy link
Contributor

Discussion

We have some debug warnings if the latest installed Chrome verison doesn't match the latest vetted Chrome version for Auth Tests. This change was originally made due the Chrome version causing certain Auth tests to fail, but determining the issue was due to a Chrome version change was cumbeersome and a second thought.

This change pushes the configuration of CHROME_VALIDATED_VERSION out of the CI workflow and into our GitHub secrets. This should let us update the value easier as it wouldn't require a PR.

Testing

CI

API Changes

None.

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 33e5711

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@DellaBitta
Copy link
Contributor Author

Silly me, we can't log secrets.

@DellaBitta DellaBitta closed this Jan 23, 2025
@google-oss-bot
Copy link
Contributor

@DellaBitta DellaBitta deleted the ddb-update-chrome-log branch January 24, 2025 15:48
@firebase firebase locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants