Skip to content

Revert the UTF-8 encoding in string sorting #8782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Revert the UTF-8 encoding in string sorting #8782

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9823808
Revert the UTF-8 encoding in string sorting
milaGGL Feb 10, 2025
064b68b
add changeset
milaGGL Feb 10, 2025
1d42607
update changeset
milaGGL Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/slimy-chicken-mix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@firebase/firestore': patch
'firebase': patch
---

Reverted a change to use UTF-8 encoding in string comparisons which caused a performance issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another drive-by comment: Append Fixes #NNNN to allow interested parties to click through to the github issue and understand more context.

Loading