test: remove files from all karma module exports
#8850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This object is not used by Karma, so I believe there is no need to export it. Karma instead uses the 'files' property that is assigned on the config object. Running tests locally, it seems that the same set of tests are ran after this change. One side-effect of this change could be that files importing the another `karma.conf.js` file may use these exported files, but I can not find cases of this.
dlarocque
requested review from
a team,
NhienLam,
Xiaoshouzi-gh,
aashishpatil-g,
avolkovi,
erikeldridge,
lisajian,
maneesht,
mansisampat,
pashanka,
sam-gc,
tonyjhuang,
visumickey,
yoyomyo and
zwu52
as code owners
|
dlarocque
changed the title
files from all karma module exports.files from all karma module exports
Contributor
Size Report 1Affected ProductsNo changes between base commit (c8cbfff) and merge commit (fcbc828).Test Logs |
Contributor
Size Analysis Report 1Affected ProductsNo changes between base commit (c8cbfff) and merge commit (fcbc828).Test Logs |
DellaBitta
approved these changes
Mar 24, 2025
dlarocque
changed the title
files from all karma module exportsfiles from all karma module exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module.exports.filesare not used by Karma, so I believe there is no need to export it. Karma instead uses thefilesproperty that is assigned on the config object. https://karma-runner.github.io/6.4/config/files.htmlRunning tests locally, it seems that the same set of tests are ran after this change.
One side-effect of this change could be that files importing the another
karma.conf.jsfile may use these exported files, but I can not find cases of this.