Fix compilation and tests failures #8902
Conversation
|
Vertex AI Mock Responses Check
|
wu-hui
force-pushed
the
push-ylruyrrpmnmz
branch
from
4ff3404 to
3ce820b
Compare
There was a problem hiding this comment.
@MarkDuckworth PTAL
I also realized that you were right, there was a getDocs(realtimePipeline) impl. I removed it for now, we can discuss with the team if an execute(realtimePipeline) is wanted.
| } from './settings'; | ||
| import { _onRealtimePipelineSnapshot } from '../../../src/api/pipeline_impl'; | ||
| import { RealtimePipeline } from '../../../src/api/realtime_pipeline'; | ||
| import { onPipelineSnapshot } from '../../../src/api/reference_impl'; |
There was a problem hiding this comment.
@MarkDuckworth This import is suspicious, just to call it out.
There was a problem hiding this comment.
I'll take another look.
| }), | ||
| json({ preferConst: true }), | ||
| json({ preferConst: true }) | ||
| //terser(util.manglePrivatePropertiesOptions) |
There was a problem hiding this comment.
needs to be re-enabled
| removeAsserts(service.getProgram()) | ||
| // renameInternals(service.getProgram(), { | ||
| // publicIdentifiers, | ||
| // prefix: '__PRIVATE_' |
| } from './settings'; | ||
| import { _onRealtimePipelineSnapshot } from '../../../src/api/pipeline_impl'; | ||
| import { RealtimePipeline } from '../../../src/api/realtime_pipeline'; | ||
| import { onPipelineSnapshot } from '../../../src/api/reference_impl'; |
There was a problem hiding this comment.
I'll take another look.
2 participants
No description provided.