Skip to content

VinF Hybrid Inference: @types/dom-chromium-ai #8920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

VinF Hybrid Inference: @types/dom-chromium-ai #8920

wants to merge 2 commits into from

Conversation

hsubox76
Copy link
Contributor

Use yarn's nohoist option to prevent @types/dom-chromium-ai from being hosted to the root-level node_modules and interfering with other packages that should not include it. We may want to look into doing this for some other @types packages as well, that could be causing interference.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d8f8fb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla Google CLA
Copy link

google-cla bot commented Apr 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hsubox76 hsubox76 changed the title Add @types/dom-chromium-ai VinF Hybrid Inference: @types/dom-chromium-ai Apr 10, 2025
@hsubox76 hsubox76 marked this pull request as ready for review April 10, 2025 17:57
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 10, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (dcc62c0) and merge commit (bf6ddf6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WDMqGMCIqf.html

@hsubox76 hsubox76 changed the base branch from vertexai-hybridinference-integration to main April 10, 2025 18:25
erikeldridge
erikeldridge reviewed Apr 10, 2025
View reviewed changes
package.json
"repo-scripts/*"
],
"nohoist": [
"**/vertexai/@types/dom-chromium-ai"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

erikeldridge
erikeldridge approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@erikeldridge erikeldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll close #8916 in favor of this change. Once this merges, I'll pull the latest main into #8874.

@erikeldridge erikeldridge mentioned this pull request Apr 10, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (dcc62c0) and merge commit (bf6ddf6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/a8vc71Q6Js.html

@hsubox76 hsubox76 force-pushed the ch-test-dom-chromium branch from b54f091 to b523528 Compare April 14, 2025 22:50
@hsubox76 hsubox76 changed the base branch from main to vertexai-hybridinference-integration April 14, 2025 22:51
@hsubox76 hsubox76 changed the base branch from vertexai-hybridinference-integration to main April 14, 2025 22:54
@hsubox76 hsubox76 force-pushed the ch-test-dom-chromium branch from b523528 to 8302584 Compare April 14, 2025 23:07
@hsubox76 hsubox76 changed the base branch from main to vertexai-hybridinference-integration April 14, 2025 23:07
@erikeldridge erikeldridge mentioned this pull request Apr 15, 2025
Closed
@hsubox76 hsubox76 closed this Jul 8, 2025
@firebase firebase locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@erikeldridge erikeldridge erikeldridge approved these changes

@visumickey visumickey Awaiting requested review from visumickey

@avolkovi avolkovi Awaiting requested review from avolkovi

@yoyomyo yoyomyo Awaiting requested review from yoyomyo

@lisajian lisajian Awaiting requested review from lisajian

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh

@sam-gc sam-gc Awaiting requested review from sam-gc

@pashanka pashanka Awaiting requested review from pashanka

@mansisampat mansisampat Awaiting requested review from mansisampat

@NhienLam NhienLam Awaiting requested review from NhienLam

@zwu52 zwu52 Awaiting requested review from zwu52

@maneesht maneesht Awaiting requested review from maneesht

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsubox76 @google-oss-bot @erikeldridge