Skip to content

VinF Hybrid Inference: remove default expected input types #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 25, 2025
Merged

VinF Hybrid Inference: remove default expected input types #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f99847b
Fix backwards compat test
erikeldridge Apr 23, 2025
a250559
Run docgen
erikeldridge Apr 23, 2025
399ebe0
Centralize onDeviceParams initialization
erikeldridge Apr 23, 2025
2e83dca
Merge remote-tracking branch 'public/vaihi-exp-google-ai' into erikel…
erikeldridge Apr 24, 2025
76a62a6
Remove default expected input types
erikeldridge Apr 24, 2025
21ec42d
Merge remote-tracking branch 'public/vaihi-exp-google-ai' into erikel…
erikeldridge Apr 24, 2025
52fa069
Reuse expected params in tests
erikeldridge Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions packages/vertexai/src/methods/chrome-adapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,14 @@ describe('ChromeAdapter', () => {
const createStub = stub(languageModelProvider, 'create').resolves(
{} as LanguageModel
);
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device'
);
const expectedOnDeviceParams = {
expectedInputs: [{ type: 'image' }]
} as LanguageModelCreateOptions;
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device',
expectedOnDeviceParams
);
expect(
await adapter.isAvailable({
contents: [{ role: 'user', parts: [{ text: 'hi' }] }]
Expand Down Expand Up @@ -221,17 +222,14 @@ describe('ChromeAdapter', () => {
);
const promptOutput = 'hi';
const promptStub = stub(languageModel, 'prompt').resolves(promptOutput);
const onDeviceParams = {
systemPrompt: 'be yourself'
} as LanguageModelCreateOptions;
const expectedOnDeviceParams = {
systemPrompt: 'be yourself',
expectedInputs: [{ type: 'image' }]
} as LanguageModelCreateOptions;
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device',
onDeviceParams
expectedOnDeviceParams
);
const request = {
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
Expand Down Expand Up @@ -270,17 +268,14 @@ describe('ChromeAdapter', () => {
);
const promptOutput = 'hi';
const promptStub = stub(languageModel, 'prompt').resolves(promptOutput);
const onDeviceParams = {
systemPrompt: 'be yourself'
} as LanguageModelCreateOptions;
const expectedOnDeviceParams = {
systemPrompt: 'be yourself',
expectedInputs: [{ type: 'image' }]
} as LanguageModelCreateOptions;
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device',
onDeviceParams
expectedOnDeviceParams
);
const request = {
contents: [
Expand Down Expand Up @@ -379,14 +374,13 @@ describe('ChromeAdapter', () => {
}
})
);
const onDeviceParams = {} as LanguageModelCreateOptions;
const expectedOnDeviceParams = {
expectedInputs: [{ type: 'image' }]
} as LanguageModelCreateOptions;
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device',
onDeviceParams
expectedOnDeviceParams
);
const request = {
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
Expand Down Expand Up @@ -423,14 +417,13 @@ describe('ChromeAdapter', () => {
}
})
);
const onDeviceParams = {} as LanguageModelCreateOptions;
const expectedOnDeviceParams = {
expectedInputs: [{ type: 'image' }]
} as LanguageModelCreateOptions;
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device',
onDeviceParams
expectedOnDeviceParams
);
const request = {
contents: [
Expand Down
9 changes: 1 addition & 8 deletions packages/vertexai/src/methods/chrome-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ export class ChromeAdapter {
private languageModelProvider?: LanguageModel,
private mode?: InferenceMode,
private onDeviceParams: LanguageModelCreateOptions = {}
) {
this.addImageTypeAsExpectedInput();
}
) {}

/**
* Checks if a given request can be made on-device.
Expand Down Expand Up @@ -237,11 +235,6 @@ export class ChromeAdapter {
return newSession;
}

private addImageTypeAsExpectedInput(): void {
// Defaults to support image inputs for convenience.
this.onDeviceParams.expectedInputs ??= [{ type: 'image' }];
}

/**
* Formats string returned by Chrome as a {@link Response} returned by Vertex.
*/
Expand Down
Loading