Minor changes after e2e tests #9098
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansisampat
requested review from
a team,
NhienLam,
Xiaoshouzi-gh,
lisajian,
pashanka and
sam-gc
as code owners
|
mansisampat
force-pushed
the
sammansi-gcip-byociam-web
branch
from
4ba78c9 to
3987be1
Compare
Contributor
Size Report 1Affected Products
Test Logs |
Contributor
Size Analysis Report 1Affected Products
Test Logs |
DellaBitta
requested changes
Jun 16, 2025
|
|
||
| export interface ExchangeTokenRequest { | ||
| parent: string; | ||
| token: string; |
Contributor
There was a problem hiding this comment.
Is this feature already public? If so, isn't this a breaking API change?
| }).slice(1); | ||
| } | ||
| console.log("here"); | ||
| console.log(queryParamString); |
Contributor
There was a problem hiding this comment.
Looks like two extra debug log statements made it in.
* Implement InitializeAuth changes for BYO-CIAM Firebase Auth * Removing white space * Addressing review comments * Adding Unit test for initializeAuth with TenantConfig dependency * Running yarn run demo * Update doc
* Throw not supported exception in _performApiRequest
mansisampat
force-pushed
the
gcip-byociam-web
branch
2 times, most recently
from
83ec04f to
44d2eb0
Compare
* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019) * Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019) * Implement exchangeToken public api * Using expiry_in returned by backend * Addressing review comments and adding some Unit test * Docgen * Addressing review comments and adding some Unit test * Typo * yarn docgen * Fixing typo * yarn run format
* Write Firebase Token to Auth instance * yarn run format * Fix unit test and run yarn docgen:all * Address comments
* Write Firebase Token to Auth instance * yarn run format * Fix unit test and run yarn docgen:all * getFirebaseToken Auth Interop method for BYO-CIAM * Add unit test * Adding Unit test * Running yarn docgen:all * Use getToken instead of getFirebaseToken * Adding Unit test * yarn run format * Remove unused method
mansisampat
force-pushed
the
gcip-byociam-web
branch
from
44d2eb0 to
1aa8468
Compare
mansisampat
force-pushed
the
sammansi-gcip-byociam-web
branch
from
52b6b99 to
70d6f9b
Compare
mansisampat
force-pushed
the
gcip-byociam-web
branch
2 times, most recently
from
b18b769 to
ac2fc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Testing