Increase unit test coverage for oauth.ts to 100% #9140

mansisampat · 2025-07-03T06:55:53Z

Discussion

Increase unit test coverage for oauth.ts to 100%
https://screenshot.googleplex.com/6y4mxpwYfT9Mj4J

Testing

Test passing locally

changeset-bot · 2025-07-03T06:55:58Z

⚠️ No Changeset found

Latest commit: f74fb07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2025-07-03T07:05:24Z

Size Report ¹

Affected Products

@firebase/ai
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 42.5 kB 63.3 kB +20.8 kB (+48.9%)
main 43.7 kB 67.1 kB +23.4 kB (+53.5%)
module 42.5 kB 63.3 kB +20.8 kB (+48.9%)
@firebase/analytics
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 21.8 kB 21.6 kB -282 B (-1.3%)
main 23.1 kB 22.8 kB -282 B (-1.2%)
module 21.8 kB 21.6 kB -282 B (-1.3%)
@firebase/app
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 19.5 kB 19.6 kB +46 B (+0.2%)
main 20.4 kB 20.5 kB +88 B (+0.4%)
module 19.5 kB 19.6 kB +46 B (+0.2%)
react-native 20.4 kB 20.5 kB +88 B (+0.4%)
@firebase/app-check
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 26.9 kB 26.4 kB -585 B (-2.2%)
main 27.9 kB 27.3 kB -585 B (-2.1%)
module 26.9 kB 26.4 kB -585 B (-2.2%)
@firebase/app-check-compat
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 2.27 kB 2.27 kB -1 B (-0.0%)
main 2.74 kB 2.74 kB -1 B (-0.0%)
module 2.27 kB 2.27 kB -1 B (-0.0%)
@firebase/app-compat
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 5.33 kB 5.25 kB -77 B (-1.4%)
main 5.90 kB 5.82 kB -77 B (-1.3%)
module 5.33 kB 5.25 kB -77 B (-1.4%)

`@firebase/auth`

Type	Base (`ab5c2a0`)	Merge (`8710d0d`)	Diff
browser	193 kB	188 kB	-5.18 kB (-2.7%)
cordova	166 kB	161 kB	-4.72 kB (-2.8%)
main	147 kB	144 kB	-3.65 kB (-2.5%)
module	193 kB	188 kB	-5.18 kB (-2.7%)
react-native	165 kB	161 kB	-4.31 kB (-2.6%)

@firebase/auth-compat
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 20.2 kB 20.0 kB -272 B (-1.3%)
main 22.4 kB 22.1 kB -272 B (-1.2%)
module 20.2 kB 20.0 kB -272 B (-1.3%)
@firebase/auth-cordova
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 166 kB 161 kB -4.72 kB (-2.8%)
module 166 kB 161 kB -4.72 kB (-2.8%)
@firebase/auth-web-extension
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 142 kB 139 kB -3.87 kB (-2.7%)
main 160 kB 156 kB -4.08 kB (-2.6%)
module 142 kB 139 kB -3.87 kB (-2.7%)
@firebase/auth/internal
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 204 kB 198 kB -6.07 kB (-3.0%)
main 174 kB 169 kB -4.62 kB (-2.7%)
module 204 kB 198 kB -6.07 kB (-3.0%)
@firebase/component
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 6.54 kB 6.38 kB -154 B (-2.4%)
main 6.87 kB 6.72 kB -154 B (-2.2%)
module 6.54 kB 6.38 kB -154 B (-2.4%)
@firebase/data-connect
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 21.7 kB 21.3 kB -416 B (-1.9%)
main 24.0 kB 23.6 kB -416 B (-1.7%)
module 21.7 kB 21.3 kB -416 B (-1.9%)
@firebase/database
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 250 kB 249 kB -281 B (-0.1%)
main 254 kB 254 kB -281 B (-0.1%)
module 250 kB 249 kB -281 B (-0.1%)
@firebase/database-compat
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 18.3 kB 18.2 kB -42 B (-0.2%)
main 18.9 kB 18.9 kB -42 B (-0.2%)
module 18.3 kB 18.2 kB -42 B (-0.2%)
@firebase/database-compat/standalone
Type Base (ab5c2a0) Merge (8710d0d) Diff
main 366 kB 366 kB -233 B (-0.1%)
@firebase/firestore
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 395 kB 391 kB -3.81 kB (-1.0%)
main 616 kB 611 kB -5.19 kB (-0.8%)
module 395 kB 391 kB -3.81 kB (-1.0%)
react-native 395 kB 392 kB -3.81 kB (-1.0%)
@firebase/firestore-compat
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 20.6 kB 20.3 kB -313 B (-1.5%)
main 21.0 kB 20.7 kB -313 B (-1.5%)
module 20.6 kB 20.3 kB -313 B (-1.5%)
react-native 20.6 kB 20.3 kB -313 B (-1.5%)
@firebase/firestore-lite
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 117 kB 115 kB -1.31 kB (-1.1%)
main 160 kB 158 kB -1.85 kB (-1.2%)
module 117 kB 115 kB -1.31 kB (-1.1%)
react-native 117 kB 116 kB -1.31 kB (-1.1%)
@firebase/functions
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 14.2 kB 14.2 kB -27 B (-0.2%)
main 14.7 kB 14.7 kB -22 B (-0.1%)
module 14.2 kB 14.2 kB -27 B (-0.2%)
@firebase/functions-compat
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 1.79 kB 1.73 kB -59 B (-3.3%)
main 2.12 kB 2.07 kB -59 B (-2.8%)
module 1.79 kB 1.73 kB -59 B (-3.3%)
@firebase/installations
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 17.8 kB 17.6 kB -126 B (-0.7%)
main 18.3 kB 18.2 kB -126 B (-0.7%)
module 17.8 kB 17.6 kB -126 B (-0.7%)
@firebase/logger
Type Base (ab5c2a0) Merge (8710d0d) Diff
main 3.83 kB 3.78 kB -46 B (-1.2%)
module 3.25 kB 3.21 kB -46 B (-1.4%)
@firebase/messaging
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 22.0 kB 21.5 kB -489 B (-2.2%)
main 22.4 kB 22.0 kB -489 B (-2.2%)
module 22.0 kB 21.5 kB -489 B (-2.2%)
@firebase/messaging-sw
Type Base (ab5c2a0) Merge (8710d0d) Diff
main 24.1 kB 23.3 kB -773 B (-3.2%)
module 23.5 kB 22.8 kB -773 B (-3.3%)
@firebase/performance
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 31.5 kB 31.2 kB -313 B (-1.0%)
main 32.0 kB 31.7 kB -313 B (-1.0%)
module 31.5 kB 31.2 kB -313 B (-1.0%)
@firebase/remote-config
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 23.2 kB 39.0 kB +15.8 kB (+67.9%)
main 24.4 kB 40.2 kB +15.9 kB (+65.2%)
module 23.2 kB 39.0 kB +15.8 kB (+67.9%)
@firebase/rules-unit-testing
Type Base (ab5c2a0) Merge (8710d0d) Diff
main 12.3 kB 11.7 kB -578 B (-4.7%)
@firebase/storage
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 58.5 kB 58.3 kB -160 B (-0.3%)
main 60.0 kB 59.8 kB -214 B (-0.4%)
module 58.5 kB 58.3 kB -160 B (-0.3%)
@firebase/storage-compat
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 5.67 kB 5.66 kB -14 B (-0.2%)
main 6.05 kB 6.04 kB -14 B (-0.2%)
module 5.67 kB 5.66 kB -14 B (-0.2%)
@firebase/util
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 29.4 kB 29.1 kB -282 B (-1.0%)
main 35.8 kB 35.5 kB -282 B (-0.8%)
module 29.4 kB 29.1 kB -282 B (-1.0%)
@firebase/webchannel-wrapper/bloom-blob
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 11.1 kB 11.3 kB +123 B (+1.1%)
main 11.1 kB 11.3 kB +123 B (+1.1%)
module 11.1 kB 11.3 kB +123 B (+1.1%)
@firebase/webchannel-wrapper/webchannel-blob
Type Base (ab5c2a0) Merge (8710d0d) Diff
browser 42.2 kB 40.9 kB -1.27 kB (-3.0%)
main 42.2 kB 40.9 kB -1.27 kB (-3.0%)
module 42.2 kB 40.9 kB -1.27 kB (-3.0%)

`bundle`

46 size changes

Type	Base (`ab5c2a0`)	Merge (`8710d0d`)	Diff
analytics (logEvent)	44.7 kB	44.1 kB	-635 B (-1.4%)
app-check (CustomProvider)	38.0 kB	37.2 kB	-793 B (-2.1%)
app-check (ReCaptchaEnterpriseProvider)	40.5 kB	39.6 kB	-933 B (-2.3%)
app-check (ReCaptchaV3Provider)	40.5 kB	39.6 kB	-933 B (-2.3%)
auth (Anonymous)	78.0 kB	74.8 kB	-3.22 kB (-4.1%)
auth (EmailAndPassword)	88.1 kB	84.5 kB	-3.62 kB (-4.1%)
auth (GoogleFBTwitterGitHubPopup)	109 kB	105 kB	-4.03 kB (-3.7%)
auth (GooglePopup)	102 kB	98.1 kB	-3.90 kB (-3.8%)
auth (GoogleRedirect)	102 kB	98.3 kB	-3.90 kB (-3.8%)
auth (Phone)	95.5 kB	91.7 kB	-3.81 kB (-4.0%)
database (Append to a list of data)	154 kB	154 kB	-790 B (-0.5%)
database (Filtering data)	153 kB	153 kB	-790 B (-0.5%)
database (Listen for child events)	170 kB	169 kB	-790 B (-0.5%)
database (Listen for value events + Detach listeners)	170 kB	169 kB	-790 B (-0.5%)
database (Listen for value events)	170 kB	169 kB	-790 B (-0.5%)
database (Read data once)	169 kB	168 kB	-790 B (-0.5%)
database (Save data as transactions)	172 kB	171 kB	-847 B (-0.5%)
database (Sort data)	155 kB	154 kB	-790 B (-0.5%)
database (Write data)	154 kB	153 kB	-790 B (-0.5%)
firestore (CSI Auto Indexing Disable and Delete)	291 kB	286 kB	-4.50 kB (-1.5%)
firestore (CSI Auto Indexing Enable)	291 kB	286 kB	-4.50 kB (-1.5%)
firestore (Persistence)	322 kB	318 kB	-3.81 kB (-1.2%)
firestore (Query Cursors)	260 kB	257 kB	-3.13 kB (-1.2%)
firestore (Query)	258 kB	255 kB	-3.23 kB (-1.3%)
firestore (Read data once)	248 kB	245 kB	-3.03 kB (-1.2%)
firestore (Read Write w Persistence)	342 kB	338 kB	-4.26 kB (-1.2%)
firestore (Realtime updates)	248 kB	245 kB	-3.13 kB (-1.3%)
firestore (Transaction)	227 kB	223 kB	-3.55 kB (-1.6%)
firestore (Write data)	228 kB	224 kB	-3.42 kB (-1.5%)
firestore-lite (Query Cursors)	111 kB	110 kB	-1.56 kB (-1.4%)
firestore-lite (Query)	107 kB	106 kB	-1.56 kB (-1.5%)
firestore-lite (Read data once)	82.9 kB	81.6 kB	-1.25 kB (-1.5%)
firestore-lite (Transaction)	108 kB	107 kB	-1.38 kB (-1.3%)
firestore-lite (Write data)	92.4 kB	91.1 kB	-1.25 kB (-1.4%)
functions (call)	39.5 kB	38.7 kB	-728 B (-1.8%)
messaging (send + receive)	47.5 kB	46.4 kB	-1.10 kB (-2.3%)
performance (trace)	63.0 kB	62.1 kB	-940 B (-1.5%)
remote-config (getAndFetch)	48.8 kB	59.4 kB	+10.6 kB (+21.8%)
storage (getBytes)	47.3 kB	46.6 kB	-693 B (-1.5%)
storage (getDownloadURL)	49.4 kB	48.7 kB	-693 B (-1.4%)
storage (getMetadata)	48.8 kB	48.1 kB	-693 B (-1.4%)
storage (list + listAll)	48.2 kB	47.5 kB	-693 B (-1.4%)
storage (updateMetadata)	49.1 kB	48.4 kB	-693 B (-1.4%)
storage (uploadBytes)	53.9 kB	53.2 kB	-693 B (-1.3%)
storage (uploadBytesResumable)	63.9 kB	63.1 kB	-733 B (-1.1%)
storage (uploadString)	54.1 kB	53.4 kB	-706 B (-1.3%)

`firebase`

32 size changes

Type	Base (`ab5c2a0`)	Merge (`8710d0d`)	Diff
firebase-ai.js	33.8 kB	49.9 kB	+16.1 kB (+47.8%)
firebase-analytics-compat.js	25.7 kB	25.4 kB	-278 B (-1.1%)
firebase-analytics.js	29.7 kB	29.4 kB	-361 B (-1.2%)
firebase-app-check-compat.js	23.1 kB	22.8 kB	-308 B (-1.3%)
firebase-app-check.js	25.5 kB	25.0 kB	-479 B (-1.9%)
firebase-app-compat.js	31.8 kB	31.6 kB	-183 B (-0.6%)
firebase-app.js	103 kB	103 kB	+21 B (+0.0%)
firebase-auth-compat.js	146 kB	142 kB	-3.11 kB (-2.1%)
firebase-auth-cordova.js	143 kB	139 kB	-3.81 kB (-2.7%)
firebase-auth-web-extension.js	125 kB	122 kB	-3.26 kB (-2.6%)
firebase-auth.js	163 kB	159 kB	-4.24 kB (-2.6%)
firebase-compat.js	807 kB	809 kB	+1.98 kB (+0.2%)
firebase-data-connect.js	22.8 kB	22.5 kB	-279 B (-1.2%)
firebase-database-compat.js	168 kB	168 kB	-211 B (-0.1%)
firebase-database.js	192 kB	192 kB	-333 B (-0.2%)
firebase-firestore-compat.js	351 kB	348 kB	-3.70 kB (-1.1%)
firebase-firestore-lite.js	140 kB	138 kB	-1.26 kB (-0.9%)
firebase-firestore.js	459 kB	454 kB	-5.05 kB (-1.1%)
firebase-functions-compat.js	14.8 kB	14.8 kB	+16 B (+0.1%)
firebase-functions.js	19.6 kB	19.5 kB	-22 B (-0.1%)
firebase-installations-compat.js	12.9 kB	12.7 kB	-123 B (-1.0%)
firebase-installations.js	15.2 kB	15.0 kB	-152 B (-1.0%)
firebase-messaging-compat.js	37.0 kB	36.3 kB	-698 B (-1.9%)
firebase-messaging-sw.js	30.1 kB	29.3 kB	-814 B (-2.7%)
firebase-messaging.js	29.1 kB	28.6 kB	-538 B (-1.8%)
firebase-performance-compat.js	40.5 kB	40.3 kB	-262 B (-0.6%)
firebase-performance-standalone-compat.js	105 kB	105 kB	-625 B (-0.6%)
firebase-performance.js	46.0 kB	45.6 kB	-414 B (-0.9%)
firebase-remote-config-compat.js	28.3 kB	38.7 kB	+10.4 kB (+36.9%)
firebase-remote-config.js	32.7 kB	43.5 kB	+10.9 kB (+33.2%)
firebase-storage-compat.js	44.3 kB	44.2 kB	-68 B (-0.2%)
firebase-storage.js	51.2 kB	51.1 kB	-141 B (-0.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/BFFjUyACKM.html

google-oss-bot · 2025-07-03T07:17:20Z

Size Analysis Report ¹

This report is too large (1,269,832 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/pwAumjuTUh.html

NhienLam · 2025-07-08T19:42:14Z

.github/workflows/test-changed-auth.yml

  CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
  CHROMEDRIVER_CDNBINARIESURL: https://storage.googleapis.com/chrome-for-testing-public
-  CHROME_VALIDATED_VERSION: linux-120.0.6099.71
+  CHROME_VALIDATED_VERSION: linux-137.0.7151.119


I think we should also update https://github.com/firebase/firebase-js-sdk/blob/main/.github/workflows/test-all.yml#L26 to have the same version.

github-actions · 2025-10-16T05:36:34Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v15.0

Increase unit test coverage for oauth.ts to 100%

d258da4

mansisampat requested review from a team, NhienLam, Xiaoshouzi-gh, lisajian, pashanka and sam-gc as code owners July 3, 2025 06:55

mansisampat added 2 commits July 3, 2025 12:29

fix lint errors

b54a402

fix lint errors

4d4c23a

mansisampat added 2 commits July 3, 2025 12:39

fix lint errors

7ece3cf

Updating the chrom version in test-changed-auth.yaml

aa83460

NhienLam requested changes Jul 8, 2025

View reviewed changes

NhienLam approved these changes Jul 8, 2025

View reviewed changes

Updating the chrome_validated_version for tests

f74fb07

Increase unit test coverage for oauth.ts to 100% #9140

Are you sure you want to change the base?

Increase unit test coverage for oauth.ts to 100% #9140

Uh oh!

Conversation

mansisampat commented Jul 3, 2025

Discussion

Testing

Uh oh!

changeset-bot bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/ai

@firebase/analytics

@firebase/app

@firebase/app-check

@firebase/app-check-compat

@firebase/app-compat

@firebase/auth

@firebase/auth-compat

@firebase/auth-cordova

@firebase/auth-web-extension

@firebase/auth/internal

@firebase/component

@firebase/data-connect

@firebase/database

@firebase/database-compat

@firebase/database-compat/standalone

@firebase/firestore

@firebase/firestore-compat

@firebase/firestore-lite

@firebase/functions

@firebase/functions-compat

@firebase/installations

@firebase/logger

@firebase/messaging

@firebase/messaging-sw

@firebase/performance

@firebase/remote-config

@firebase/rules-unit-testing

@firebase/storage

@firebase/storage-compat

@firebase/util

@firebase/webchannel-wrapper/bloom-blob

@firebase/webchannel-wrapper/webchannel-blob

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Test Logs

Uh oh!

NhienLam Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 16, 2025

Vertex AI Mock Responses Check ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Jul 3, 2025 •

edited

Loading

google-oss-bot commented Jul 3, 2025 •

edited

Loading

Size Report ¹

`@firebase/ai`

`@firebase/analytics`

`@firebase/app`

`@firebase/app-check`

`@firebase/app-check-compat`

`@firebase/app-compat`

`@firebase/auth`

`@firebase/auth-compat`

`@firebase/auth-cordova`

`@firebase/auth-web-extension`

`@firebase/auth/internal`

`@firebase/component`

`@firebase/data-connect`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/functions-compat`

`@firebase/installations`

`@firebase/logger`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/performance`

`@firebase/remote-config`

`@firebase/rules-unit-testing`

`@firebase/storage`

`@firebase/storage-compat`

`@firebase/util`

`@firebase/webchannel-wrapper/bloom-blob`

`@firebase/webchannel-wrapper/webchannel-blob`

`bundle`

`firebase`

google-oss-bot commented Jul 3, 2025 •

edited

Loading

Size Analysis Report ¹