Skip to content

docs(firestore): add an example to the detailed comment in compareUtf8Strings() #9154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jul 8, 2025

This PR enhances the documentation for the compareUtf8Strings() method by adding a concrete example. This example illustrates the nuances of comparing Unicode strings, particularly how characters represented by surrogate pairs in UTF-16 can compare differently than the lexicographical comparison of their UTF-8 encoding.

This PR is in response to review comment firebase/firebase-android-sdk#7098 (review) and is a port of firebase/firebase-android-sdk#7113

@dconeybe dconeybe self-assigned this Jul 8, 2025
@dconeybe dconeybe requested review from a team as code owners July 8, 2025 01:03
Copy link

changeset-bot bot commented Jul 8, 2025

⚠️ No Changeset found

Latest commit: bb4653d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dconeybe dconeybe requested a review from MarkDuckworth July 8, 2025 01:10
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 8, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 8, 2025

@dconeybe dconeybe merged commit 47b154c into main Jul 9, 2025
80 of 87 checks passed
@dconeybe dconeybe deleted the dconeybe/firestore/Utf8StringCompareCommentExample branch July 9, 2025 14:40
@firebase firebase locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants