Skip to content

Gcip byociam refresh #9158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: gcip-byociam-web
Choose a base branch
from
Draft

Gcip byociam refresh #9158

wants to merge 12 commits into from

Conversation

mansisampat
Copy link
Contributor

Discussion

  • Expose a callback function that is triggered for token refresh

Testing

  • Unit test: todo
  • Testing done via demo app

API Changes

  • API Proposal: Todo

mansisampat added 10 commits June 18, 2025 13:17
@mansisampat
GCIP BYO-CIAM Initialize Auth Changes (#8995)
3f717af 
* Implement InitializeAuth changes for BYO-CIAM Firebase Auth

* Removing white space

* Addressing review comments

* Adding Unit test for initializeAuth with TenantConfig dependency

* Running yarn run demo

* Update doc
@mansisampat
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013)
7ef8617 
* Throw not supported exception in _performApiRequest
@mansisampat
Implement exchangeToken public api (#9039)
fbb6ac9 
* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)

* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)

* Implement exchangeToken public api

* Using expiry_in returned by backend

* Addressing review comments and adding some Unit test

* Docgen

* Addressing review comments and adding some Unit test

* Typo

* yarn docgen

* Fixing typo

* yarn run format
@mansisampat
Write Firebase Token to Auth instance during exchange_token API (#9060)
cc4b7fc 
* Write Firebase Token to Auth instance

* yarn run format

* Fix unit test and run yarn docgen:all

* Address comments
@mansisampat
Implement getToken method for Regional Auth Interop (#9061)
1aa8468 
* Write Firebase Token to Auth instance

* yarn run format

* Fix unit test and run yarn docgen:all

* getFirebaseToken Auth Interop method for BYO-CIAM

* Add unit test

* Adding Unit test

* Running yarn docgen:all

* Use getToken instead of getFirebaseToken

* Adding Unit test

* yarn run format

* Remove unused method
@mansisampat
Pass API Key as request param for Regional Auth requests & Demo App c…
7a0a879 
…hanges (#9102)

* Pass API Key as request param for Regional Auth requests

* Format

* Update chrome version

* Update chrome version

* Update chrome version

* Update chrome version

* Update chrome version

* Update chrome version

* BYO-CIAM Demo App Changes (#9106)

* BYO-CIAM Demo App Changes
@mansisampat
Fix typo
15b2302
@mansisampat
Store FirebaseToken to persistence - Required for BYO-CIAM (#9138)
5c01436 
* Maintain persistence for firebaseToken in AuthImpl object

* Adding Unit Test for auth_impl firebaseToken
@mansisampat
Maintain persistence for firebaseToken in AuthImpl object
010e0cc
@mansisampat
Expose a callback function that is triggered for token refresh
0a55186
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dbdce18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mansisampat mansisampat marked this pull request as draft July 9, 2025 05:11
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 9, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (5c01436)Merge (746fb93)Diff
    browser197 kB199 kB+1.38 kB (+0.7%)
    cordova170 kB171 kB+1.36 kB (+0.8%)
    main152 kB153 kB+1.37 kB (+0.9%)
    module197 kB199 kB+1.38 kB (+0.7%)
    react-native170 kB171 kB+1.37 kB (+0.8%)

  • @firebase/auth-cordova

    TypeBase (5c01436)Merge (746fb93)Diff
    browser170 kB171 kB+1.36 kB (+0.8%)
    module170 kB171 kB+1.36 kB (+0.8%)

  • @firebase/auth-web-extension

    TypeBase (5c01436)Merge (746fb93)Diff
    browser146 kB148 kB+1.36 kB (+0.9%)
    main164 kB165 kB+1.37 kB (+0.8%)
    module146 kB148 kB+1.36 kB (+0.9%)

  • @firebase/auth/internal

    TypeBase (5c01436)Merge (746fb93)Diff
    browser208 kB209 kB+1.38 kB (+0.7%)
    main178 kB179 kB+1.37 kB (+0.8%)
    module208 kB209 kB+1.38 kB (+0.7%)

  • bundle

    TypeBase (5c01436)Merge (746fb93)Diff
    auth (Anonymous)79.8 kB81.7 kB+1.88 kB (+2.4%)
    auth (EmailAndPassword)89.9 kB91.8 kB+1.88 kB (+2.1%)
    auth (GoogleFBTwitterGitHubPopup)111 kB113 kB+1.90 kB (+1.7%)
    auth (GooglePopup)104 kB106 kB+1.90 kB (+1.8%)
    auth (GoogleRedirect)104 kB106 kB+1.90 kB (+1.8%)
    auth (Phone)97.4 kB99.2 kB+1.88 kB (+1.9%)

  • firebase

    TypeBase (5c01436)Merge (746fb93)Diff
    firebase-auth-compat.js147 kB149 kB+1.70 kB (+1.2%)
    firebase-auth-cordova.js146 kB147 kB+969 B (+0.7%)
    firebase-auth-web-extension.js128 kB129 kB+969 B (+0.8%)
    firebase-auth.js166 kB167 kB+985 B (+0.6%)
    firebase-compat.js804 kB806 kB+1.68 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HrHF2f3h7k.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 9, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (377,968 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nFuWM0Dxng.html

@mansisampat mansisampat force-pushed the gcip-byociam-web branch 2 times, most recently from b18b769 to ac2fc52 Compare September 25, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mansisampat @google-oss-bot