fix(ai): Fix test script broken by #9232 #9235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8194d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsTest Logs |
Size Analysis Report 1Affected Products
Test Logs |
DellaBitta
requested changes
Aug 29, 2025
packages/ai/src/factory-browser.ts
Outdated
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| import { ComponentContainer, InstanceFactoryOptions } from "@firebase/component"; | |||
DellaBitta
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the emergency fix for #9232, overlooked that the
factoryexport was being used by a test utility. Refactored so that the test utility can use it without exporting it in the public API.Also added a tsc type check to the tests, that would have caught this.