Skip to content

Add ABT support for remote config #9277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 29, 2025
Merged

Add ABT support for remote config #9277

merged 16 commits into from
Sep 29, 2025

Conversation

@athiramanu
Copy link
Contributor

@athiramanu athiramanu commented Sep 25, 2025 •
edited
Loading

This change is part of the feature to support Web Experiments in Remote Config. The change is split into 3 PRs where:

  1. Introduces the experiment details in the fetch response type
  2. Extracts experiments received from the fetch response and saves in indexedDB
  3. Sets the experiment and variant received as user property

This is 2/3 mentioned above

Design doc (internal): go/experiments-web

@athiramanu athiramanu requested review from a team and erikeldridge as code owners September 25, 2025 07:20
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b2d492c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/remote-config

    TypeBase (8ee4b72)Merge (1370c50)Diff
    browser39.1 kB40.8 kB+1.63 kB (+4.2%)
    main40.4 kB42.0 kB+1.63 kB (+4.0%)
    module39.1 kB40.8 kB+1.63 kB (+4.2%)

  • bundle

    TypeBase (8ee4b72)Merge (1370c50)Diff
    remote-config (getAndFetch)59.5 kB60.4 kB+913 B (+1.5%)

  • firebase

    TypeBase (8ee4b72)Merge (1370c50)Diff
    firebase-compat.js809 kB810 kB+868 B (+0.1%)
    firebase-remote-config-compat.js38.7 kB39.6 kB+868 B (+2.2%)
    firebase-remote-config.js43.6 kB44.5 kB+911 B (+2.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BzfJOsZS9W.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 25, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/remote-config

    • activate

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size23.6 kB24.5 kB+911 B (+3.9%)
      size-with-ext-deps50.1 kB51.0 kB+913 B (+1.8%)

      Dependency

      TypeBase (8ee4b72)Merge (1370c50)Diff
      classes

      12 dependencies

      CachingClient
EventEmitter
InMemoryStorage
IndexedDbStorage
RealtimeHandler
RemoteConfig
RemoteConfigAbortSignal
RestClient
RetryingClient
Storage
StorageCache
VisibilityMonitor

      13 dependencies

      CachingClient
EventEmitter
Experiment
InMemoryStorage
IndexedDbStorage
RealtimeHandler
RemoteConfig
RemoteConfigAbortSignal
RestClient
RetryingClient
Storage
StorageCache
VisibilityMonitor

      + Experiment

    • ensureInitialized

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size23.2 kB23.3 kB+125 B (+0.5%)
      size-with-ext-deps49.7 kB49.8 kB+125 B (+0.3%)

    • fetchAndActivate

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size24.2 kB25.1 kB+913 B (+3.8%)
      size-with-ext-deps50.7 kB51.6 kB+913 B (+1.8%)

      Dependency

      TypeBase (8ee4b72)Merge (1370c50)Diff
      classes

      12 dependencies

      CachingClient
EventEmitter
InMemoryStorage
IndexedDbStorage
RealtimeHandler
RemoteConfig
RemoteConfigAbortSignal
RestClient
RetryingClient
Storage
StorageCache
VisibilityMonitor

      13 dependencies

      CachingClient
EventEmitter
Experiment
InMemoryStorage
IndexedDbStorage
RealtimeHandler
RemoteConfig
RemoteConfigAbortSignal
RestClient
RetryingClient
Storage
StorageCache
VisibilityMonitor

      + Experiment

    • fetchConfig

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size23.8 kB23.9 kB+125 B (+0.5%)
      size-with-ext-deps50.3 kB50.4 kB+125 B (+0.2%)

    • getAll

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size24.4 kB24.5 kB+125 B (+0.5%)
      size-with-ext-deps50.9 kB51.0 kB+125 B (+0.2%)

    • getBoolean

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size24.2 kB24.3 kB+125 B (+0.5%)
      size-with-ext-deps50.7 kB50.8 kB+125 B (+0.2%)

    • getNumber

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size24.2 kB24.3 kB+125 B (+0.5%)
      size-with-ext-deps50.7 kB50.8 kB+125 B (+0.2%)

    • getRemoteConfig

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size24.0 kB24.1 kB+125 B (+0.5%)
      size-with-ext-deps57.4 kB57.5 kB+125 B (+0.2%)

    • getString

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size24.2 kB24.3 kB+125 B (+0.5%)
      size-with-ext-deps50.7 kB50.8 kB+125 B (+0.2%)

    • getValue

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size24.2 kB24.3 kB+125 B (+0.5%)
      size-with-ext-deps50.7 kB50.8 kB+125 B (+0.2%)

    • isSupported

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size23.3 kB23.4 kB+125 B (+0.5%)
      size-with-ext-deps49.8 kB49.9 kB+125 B (+0.3%)

    • onConfigUpdate

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size23.3 kB23.4 kB+125 B (+0.5%)
      size-with-ext-deps49.8 kB49.9 kB+125 B (+0.3%)

    • setCustomSignals

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size23.7 kB23.8 kB+125 B (+0.5%)
      size-with-ext-deps50.2 kB50.3 kB+125 B (+0.2%)

    • setLogLevel

      Size

      TypeBase (8ee4b72)Merge (1370c50)Diff
      size23.4 kB23.5 kB+125 B (+0.5%)
      size-with-ext-deps49.9 kB50.0 kB+125 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0QnBKO2YeK.html

@athiramanu athiramanu changed the title feat: Add ABT support for remote config Add ABT support for remote config Sep 25, 2025
@athiramanu athiramanu changed the base branch from web-exp-fetch to web-experiment September 26, 2025 01:25
@athiramanu athiramanu requested a review from a team as a code owner September 26, 2025 01:25
ashish-kothari
ashish-kothari approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@ashish-kothari ashish-kothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left couple of minor comments.

@athiramanu athiramanu merged commit 17126e9 into web-experiment Sep 29, 2025
34 checks passed
@athiramanu athiramanu deleted the web-exp-abt branch September 29, 2025 17:32
@firebase firebase locked and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ashish-kothari ashish-kothari ashish-kothari approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@dsjadaun-google dsjadaun-google Awaiting requested review from dsjadaun-google

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@athiramanu @google-oss-bot @ashish-kothari @hsubox76