Integrate experiments with firebase analytics internal #9278

athiramanu · 2025-09-25T08:22:54Z

This change is part of the feature to support Web Experiments in Remote Config. The change is split into 3 PRs where:

Introduces the experiment details in the fetch response type
Extracts experiments received from the fetch response and saves in indexedDB
Sets the experiment and variant received as user property

This is 3/3 mentioned above

Design doc (internal): go/experiments-web

…response

changeset-bot · 2025-09-25T08:22:59Z

⚠️ No Changeset found

Latest commit: 76fd2ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2025-09-25T09:24:24Z

Size Report ¹

Affected Products

@firebase/remote-config
Type Base (17126e9) Merge (44aee84) Diff
browser 40.8 kB 41.5 kB +710 B (+1.7%)
main 42.0 kB 42.7 kB +710 B (+1.7%)
module 40.8 kB 41.5 kB +710 B (+1.7%)
bundle
Type Base (17126e9) Merge (44aee84) Diff
remote-config (getAndFetch) 60.4 kB 60.9 kB +517 B (+0.9%)
firebase
Type Base (17126e9) Merge (44aee84) Diff
firebase-compat.js 810 kB 811 kB +488 B (+0.1%)
firebase-remote-config-compat.js 39.6 kB 40.1 kB +487 B (+1.2%)
firebase-remote-config.js 44.5 kB 45.0 kB +494 B (+1.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/vBSHpKNpHT.html

google-oss-bot · 2025-09-25T09:36:12Z

Size Analysis Report ¹

Affected Products

@firebase/remote-config
- activate
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 24.5 kB 25.0 kB +516 B (+2.1%)
  size-with-ext-deps 51.0 kB 51.5 kB +517 B (+1.0%)
- ensureInitialized
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 23.3 kB 23.5 kB +167 B (+0.7%)
  size-with-ext-deps 49.8 kB 50.0 kB +167 B (+0.3%)
- fetchAndActivate
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 25.1 kB 25.6 kB +516 B (+2.1%)
  size-with-ext-deps 51.6 kB 52.1 kB +517 B (+1.0%)
- fetchConfig
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 23.9 kB 24.1 kB +167 B (+0.7%)
  size-with-ext-deps 50.4 kB 50.6 kB +167 B (+0.3%)
- getAll
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 24.5 kB 24.7 kB +167 B (+0.7%)
  size-with-ext-deps 51.0 kB 51.1 kB +167 B (+0.3%)
- getBoolean
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 24.3 kB 24.5 kB +167 B (+0.7%)
  size-with-ext-deps 50.8 kB 51.0 kB +167 B (+0.3%)
- getNumber
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 24.3 kB 24.5 kB +167 B (+0.7%)
  size-with-ext-deps 50.8 kB 51.0 kB +167 B (+0.3%)
- getRemoteConfig
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 24.1 kB 24.3 kB +167 B (+0.7%)
  size-with-ext-deps 57.5 kB 57.7 kB +167 B (+0.3%)
- getString
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 24.3 kB 24.5 kB +167 B (+0.7%)
  size-with-ext-deps 50.8 kB 51.0 kB +167 B (+0.3%)
- getValue
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 24.3 kB 24.5 kB +167 B (+0.7%)
  size-with-ext-deps 50.8 kB 51.0 kB +167 B (+0.3%)
- isSupported
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 23.4 kB 23.6 kB +167 B (+0.7%)
  size-with-ext-deps 49.9 kB 50.1 kB +167 B (+0.3%)
- onConfigUpdate
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 23.4 kB 23.6 kB +167 B (+0.7%)
  size-with-ext-deps 49.9 kB 50.1 kB +167 B (+0.3%)
- setCustomSignals
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 23.8 kB 24.0 kB +167 B (+0.7%)
  size-with-ext-deps 50.3 kB 50.5 kB +167 B (+0.3%)
- setLogLevel
  Size
  Type Base (17126e9) Merge (44aee84) Diff
  size 23.5 kB 23.6 kB +167 B (+0.7%)
  size-with-ext-deps 50.0 kB 50.1 kB +167 B (+0.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/sukkNynJRn.html

packages/remote-config/src/abt/experiment.ts

packages/remote-config/src/api.ts

hsubox76 · 2025-10-01T17:16:58Z

packages/remote-config/src/abt/experiment.ts

+        customProperty[experimentId] = null;
      }
    }
+    void this.addExperimentToAnalytics(customProperty);


Is this supposed to be remove?

Sorry, i missed this comment. The function was removed since it had the same flow as add but with null as value. Corresponding comment - #9278 (comment)

packages/remote-config/src/abt/experiment.ts

hsubox76 · 2025-10-02T01:43:09Z

packages/remote-config/src/abt/experiment.ts

+        customProperty[experimentId] = null;
      }
    }
+    this.addExperimentToAnalytics(customProperty);


Sorry if this is a duplicate comment - I can't see the previous one I left anymore - but this should be removeExperimentFromAnalytics, right?

This was removed as per #9278 (comment)

Athira M added 19 commits June 6, 2025 23:33

feat: Process experiment metadata in RC fetch response

2ec305d

feat: Add ABT support for remote config

5eb6b8d

feat: Integrate firebase internal analytics with ABT

08c8863

Merge branch 'web-experiment' into web-exp-fetch

4af3eb9

Merge branch 'web-exp-fetch' into web-exp-abt

b6f2ac9

Merge branch 'web-exp-abt' into web-exp-ga

55db6e0

[Fix] Storage cache is not updating when there are no experiments in …

24848c4

…response

[Fix] Update experiments after checking fetch response

455b8e3

Merge branch 'web-exp-abt' into web-exp-ga

e2024d7

feat: Process experiment metadata in RC fetch response

bec6e56

[Fix] Storage cache is not updating when there are no experiments in …

ee703b9

…response

Add result of running yarn docgen:all

7c67f85

feat: Process experiment metadata in RC fetch response

06398f6

feat: Add ABT support for remote config

fd049e2

[Fix] Storage cache is not updating when there are no experiments in …

638cc2c

…response

Merge conflict fix

900eff5

Yarn format fix

432ac24

Fix merge conflicts

ccc71e1

merge web-exp-abt

5836eaf

Integrate ABT with Firebase analytics to add experiment as UP

6be23df

athiramanu changed the title ~~feat: Integrate experiments with firebase analytics internal~~ Integrate experiments with firebase analytics internal Sep 25, 2025

athiramanu force-pushed the web-exp-ga branch from f4f7ce2 to b210bbb Compare September 25, 2025 09:28

Fix yarn format errors

66b104b

athiramanu force-pushed the web-exp-ga branch from b210bbb to 66b104b Compare September 25, 2025 09:33

Athira M added 3 commits September 25, 2025 23:02

Address review comments

b289636

Fix yarn format failures

d3e0838

yarn docgen changes added

aa7751e

Athira M added 3 commits September 26, 2025 06:31

Export firebaseExperimentDescription

19c0fd6

Merge branch 'web-exp-fetch' into web-exp-abt

b3f5fa1

Merge branch 'web-exp-abt' into web-exp-ga

27cb4b2

athiramanu changed the base branch from web-exp-abt to web-experiment September 26, 2025 01:26

athiramanu requested review from ashish-kothari, dsjadaun-google and hsubox76 September 26, 2025 01:27

athiramanu marked this pull request as ready for review September 26, 2025 01:27

athiramanu requested review from a team and erikeldridge as code owners September 26, 2025 01:27

ashish-kothari reviewed Sep 26, 2025

View reviewed changes

packages/remote-config/src/abt/experiment.ts Outdated Show resolved Hide resolved

packages/remote-config/src/abt/experiment.ts Outdated Show resolved Hide resolved

packages/remote-config/src/abt/experiment.ts Show resolved Hide resolved

Athira M added 2 commits September 29, 2025 23:07

Merge branch 'web-experiment' into web-exp-ga

d09a338

Address review comments

4c19690

dsjadaun-google approved these changes Sep 30, 2025

View reviewed changes

hsubox76 reviewed Sep 30, 2025

View reviewed changes

packages/remote-config/src/abt/experiment.ts Outdated Show resolved Hide resolved

packages/remote-config/src/abt/experiment.ts Outdated Show resolved Hide resolved

Athira M added 2 commits October 1, 2025 09:47

Address review comments

4eba42d

Add unit tests

bbc8f4d

athiramanu requested a review from hsubox76 October 1, 2025 05:47

hsubox76 requested changes Oct 1, 2025

View reviewed changes

packages/remote-config/src/abt/experiment.ts Show resolved Hide resolved

packages/remote-config/src/abt/experiment.ts Outdated Show resolved Hide resolved

packages/remote-config/src/api.ts Outdated Show resolved Hide resolved

hsubox76 reviewed Oct 1, 2025

View reviewed changes

Add error handling

b53e512

athiramanu requested a review from hsubox76 October 1, 2025 17:52

hsubox76 requested changes Oct 2, 2025

View reviewed changes

Remove log

76fd2ad

hsubox76 approved these changes Oct 2, 2025

View reviewed changes

athiramanu merged commit a19c1a7 into web-experiment Oct 2, 2025
34 checks passed

athiramanu deleted the web-exp-ga branch October 2, 2025 18:42

Integrate experiments with firebase analytics internal #9278

Integrate experiments with firebase analytics internal #9278

Uh oh!

Conversation

athiramanu commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/remote-config

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/remote-config

activate

ensureInitialized

fetchAndActivate

fetchConfig

getAll

getBoolean

getNumber

getRemoteConfig

getString

getValue

isSupported

onConfigUpdate

setCustomSignals

setLogLevel

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hsubox76 Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

athiramanu Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hsubox76 Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

athiramanu Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

athiramanu commented Sep 25, 2025 •

edited

Loading

changeset-bot bot commented Sep 25, 2025 •

edited

Loading

google-oss-bot commented Sep 25, 2025 •

edited

Loading

Size Report ¹

`@firebase/remote-config`

`bundle`

`firebase`

google-oss-bot commented Sep 25, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/remote-config`

`activate`

`ensureInitialized`

`fetchAndActivate`

`fetchConfig`

`getAll`

`getBoolean`

`getNumber`

`getRemoteConfig`

`getString`

`getValue`

`isSupported`

`onConfigUpdate`

`setCustomSignals`

`setLogLevel`