Skip to content

Demo app improvements. #9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2025
Merged

Demo app improvements. #9299

merged 4 commits into from
Oct 7, 2025

Conversation

mansisampat
Copy link
Contributor

Demo app improvements.

Deployed the demo app - https://manandarji-testproject-2.web.app/

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b0b2911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pashanka
pashanka reviewed Oct 7, 2025
View reviewed changes
packages/auth/demo/src/index.js Outdated
onAuthError({
code: 'auth-not-initialized',
message:
'Regional Auth is not initialized. Please enter a Tenant ID and initialize.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is the same at multiple places, do you want to move it to a separate function called, validateRegionalAuth() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 7, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (9edb9ac) and merge commit (6f470d1).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/55nZdXbbwM.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 7, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (9edb9ac) and merge commit (6f470d1).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Y0hjN5k34r.html

@mansisampat mansisampat merged commit c7f9c60 into gcip-byociam-web Oct 7, 2025
56 of 61 checks passed
@mansisampat mansisampat deleted the demo-app branch October 7, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashanka pashanka pashanka approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mansisampat @google-oss-bot @pashanka