Skip to content

Fix feature defects if Web Experiments #9327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 25, 2025
Merged

Fix feature defects if Web Experiments #9327

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86af43e
Bug fixes
Oct 17, 2025
8128ae9
yarn format fail
Oct 17, 2025
00eb10b
update event name
Oct 18, 2025
78977a6
Ensure user property is parsed
Oct 21, 2025
88d0a1c
Add firebase prefix to exp
Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/remote-config/src/abt/experiment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class Experiment {
const currentActiveExperiments =
(await this.storage.getActiveExperiments()) || new Set<string>();
const experimentInfoMap = this.createExperimentInfoMap(latestExperiments);
this.addActiveExperiments(currentActiveExperiments, experimentInfoMap);
this.addActiveExperiments(experimentInfoMap);
this.removeInactiveExperiments(currentActiveExperiments, experimentInfoMap);
return this.storage.setActiveExperiments(new Set(experimentInfoMap.keys()));
}
Expand All @@ -55,14 +55,11 @@ export class Experiment {
}

private addActiveExperiments(
currentActiveExperiments: Set<string>,
experimentInfoMap: Map<string, FirebaseExperimentDescription>
): void {
const customProperty: Record<string, string | null> = {};
for (const [experimentId, experimentInfo] of experimentInfoMap.entries()) {
if (!currentActiveExperiments.has(experimentId)) {
customProperty[experimentId] = experimentInfo.variantId;
}
customProperty[experimentId] = experimentInfo.variantId;
}
this.addExperimentToAnalytics(customProperty);
}
Expand Down Expand Up @@ -90,6 +87,7 @@ export class Experiment {
const analytics = this.analyticsProvider.getImmediate({ optional: true });
if (analytics) {
analytics.setUserProperties({ properties: customProperty });
analytics.logEvent(`Received ABT experiment update`);
Copy link
Contributor

@hsubox76 hsubox76 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are event names allowed to have spaces? I think it might be safer to use "set_firebase_experiment_state" as Sam suggested.

Copy link
Contributor Author

@athiramanu athiramanu Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

} else {
this.logger.warn(`Analytics import failed`);
}
Expand Down
5 changes: 3 additions & 2 deletions packages/remote-config/test/abt/experiment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ describe('Experiment', () => {
storage.getActiveExperiments = sinon.stub();
storage.setActiveExperiments = sinon.stub();
analyticsProvider.getImmediate = sinon.stub().returns({
setUserProperties: sinon.stub()
setUserProperties: sinon.stub(),
logEvent: sinon.stub()
});
});

Expand Down Expand Up @@ -81,7 +82,7 @@ describe('Experiment', () => {
expectedStoredExperiments
);
expect(analytics.setUserProperties).to.have.been.calledWith({
properties: { '_exp_3': '1' }
properties: { '_exp_3': '1', '_exp_1': '2', '_exp_2': '1' }
});
});

Expand Down
Loading