Skip to content

Update registerStateListener internal method signature and structure #9337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 28, 2025
Merged

Update registerStateListener internal method signature and structure #9337

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
95babba
Update registerStateListener internal method signature and structure
mansisampat Oct 21, 2025
9d79315
Update params of registerStateListener method
mansisampat Oct 27, 2025
1f5d0d2
Update logic to callback
mansisampat Oct 27, 2025
7fbf586
running yarn run format
mansisampat Oct 27, 2025
f8606d8
running yarn run format
mansisampat Oct 27, 2025
5c48067
running yarn run format
mansisampat Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/auth/src/core/auth/auth_impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,9 +814,9 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
}
}

private registerStateListener(
subscription: Subscription<User>,
nextOrObserver: NextOrObserver<User>,
private registerStateListener<T>(
subscription: Subscription<T>,
nextOrObserver: NextOrObserver<T>,
error?: ErrorFn,
completed?: CompleteFn
): Unsubscribe {
Expand All @@ -841,7 +841,14 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
if (isUnsubscribed) {
return;
}
cb(this.currentUser);
if (
(subscription as unknown) === this.idTokenSubscription ||
(subscription as unknown) === this.authStateSubscription
) {
cb(this.currentUser as unknown as T);
} else if ((subscription as unknown) === this.firebaseTokenSubscription) {
cb(this.firebaseToken as unknown as T);
}
});

if (typeof nextOrObserver === 'function') {
Expand Down
Loading