Skip to content

build(deps): update optional react-native-async-storage peerDependency to v2+ #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build(deps): update optional react-native-async-storage peerDependency to v2+ #9385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
},
"peerDependencies": {
"@firebase/app": "0.x",
"@react-native-async-storage/async-storage": "^1.18.1"
"@react-native-async-storage/async-storage": "^2.2.0"
Copy link

@gemini-code-assist gemini-code-assist bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified version ^2.2.0 for @react-native-async-storage/async-storage does not exist, which will break dependency installation. All available versions for this package are in the 1.x.x range.

Based on your pull request description, it seems you intended to raise the minimum required version to resolve a dependency conflict. You linked to version 1.21.0, so I've suggested using ^1.21.0 below. Please verify if this or a more recent stable version is what you intended.

Suggested change
"@react-native-async-storage/async-storage": "^2.2.0"
"@react-native-async-storage/async-storage": "^1.21.0"

Copy link
Author

@mikehardy mikehardy Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an absurdly bad PR review because it directly contradicts observable facts which I have linked to in the PR description above

v2.2.0 is definitely the most recent stable version and is definitely the one we want.

Bad gemini-code-assist, no biscuit!

Copy link

@gemini-code-assist gemini-code-assist bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, mikehardy! You are absolutely correct. I have re-checked the npm registry for @react-native-async-storage/async-storage, and version 2.2.0 (and indeed the 2.x.x series) is available. My information was outdated, and I regret the incorrect assessment.

Thank you for pointing out my error and providing the correct context. The change to ^2.2.0 is indeed appropriate and aligns with the most recent stable version. This is a good change.

},
"peerDependenciesMeta": {
"@react-native-async-storage/async-storage": {
Expand Down
Loading