-
Notifications
You must be signed in to change notification settings - Fork 993
WIP: Caching #9439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maneesht
wants to merge
32
commits into
main
Choose a base branch
from
mtewani/caching-first-pass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Caching #9439
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
e0a1861
First pass
maneesht 32facb6
Added caching support
maneesht 0229168
WIP
maneesht bcd9ebe
Done with first pass
maneesht 764d4ee
Fixed test
maneesht e476774
WIP
maneesht b079c53
Renamed files
maneesht 189833b
Final indexeddb pass
maneesht c83b140
Fixed temp
maneesht a5b8fe6
WIP
maneesht 78c71fc
Fix build
maneesht 4058d93
WIP
maneesht 3eae4e3
Fixed bdo parsing
maneesht d86e71f
InMemoryCacheProvider added
maneesht fcd22d5
Second pass
maneesht 7472d5d
Completed first pass of caching
maneesht 9f17eac
Fixed formatting
maneesht 4a8c6fd
Added todo
maneesht a94c607
Added entity id tracking
maneesht beaaa5c
Added todo for later
maneesht 69bc0ec
Completed most todos
maneesht 79a4031
Wrote unit test for caching
maneesht 019b4a7
Added maxAge
maneesht 0b8523b
Removed unnecessary types
maneesht 15faa32
Fixed onComplete issue
maneesht 223a1fa
Got all tests to pass
maneesht e338976
Fixed extensions parsing algorithm
maneesht 7e86e48
Added SSR
maneesht 1c189df
Cleaned up api
maneesht c50f7a8
Addressed gemini comment for register.ts
maneesht baba5c0
Fixed formatting
maneesht e9fbf67
Removed unnecessary file
maneesht File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
e2e/data-connect/dataconnect-generated/js/default-connector/.guides/setup.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Setup | ||
|
|
||
| If the user hasn't already installed the SDK, always run the user's node package manager of choice, and install the package in the directory ../package.json. | ||
| For more information on where the library is located, look at the connector.yaml file. | ||
|
|
||
| ```ts | ||
| import { initializeApp } from 'firebase/app'; | ||
|
|
||
| initializeApp({ | ||
| // fill in your project config here using the values from your Firebase project or from the `firebase_get_sdk_config` tool from the Firebase MCP server. | ||
| }); | ||
| ``` | ||
|
|
||
| Then, you can run the SDK as needed. | ||
| ```ts | ||
| import { ... } from '@firebasegen/default-connector'; | ||
| ``` | ||
|
|
||
|
|
||
|
|
27 changes: 27 additions & 0 deletions
27
e2e/data-connect/dataconnect-generated/js/default-connector/.guides/usage.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Basic Usage | ||
|
|
||
| Always prioritize using a supported framework over using the generated SDK | ||
| directly. Supported frameworks simplify the developer experience and help ensure | ||
| best practices are followed. | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| ## Advanced Usage | ||
| If a user is not using a supported framework, they can use the generated SDK directly. | ||
|
|
||
| Here's an example of how to use it with the first 5 operations: | ||
|
|
||
| ```js | ||
| import { createMovie, listMovies } from '@firebasegen/default-connector'; | ||
|
|
||
|
|
||
| // Operation CreateMovie: For variables, look at type CreateMovieVars in ../index.d.ts | ||
| const { data } = await CreateMovie(dataConnect, createMovieVars); | ||
|
|
||
| // Operation ListMovies: | ||
| const { data } = await ListMovies(dataConnect); | ||
|
|
||
|
|
||
| ``` | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.