Crashlytics tracing onboarding improvements#9587
Crashlytics tracing onboarding improvements#9587MaesterChestnut wants to merge 5 commits intocrashlytics-tracingfrom
Conversation
MaesterChestnut
commented
Feb 23, 2026
MaesterChestnut
commented
- Use endpointUrl for easier compatibility with the Crashlytics js-sdk
- Specify port for usage with local proxy url
|
MaesterChestnut
requested review from
anitdas
and removed request for
a team
Summary of ChangesHello @MaesterChestnut, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Crashlytics tracing onboarding process by standardizing endpoint configuration and updating core dependencies. The primary goal is to enhance compatibility with the Crashlytics JavaScript SDK and improve local development workflows for tracing data, ensuring a more robust and consistent setup for telemetry. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to improve Crashlytics tracing onboarding by renaming loggingUrl to endpointUrl for better compatibility and specifying a port for local proxy usage. The renaming is applied consistently across the API surfaces. However, the implementation for the local proxy URL introduces a critical issue by hardcoding a development-specific URL, which would negatively impact non-local environments. Additionally, the yarn.lock file appears to be corrupted with duplicate entries, likely from the dependency updates, and needs to be regenerated.
| const tracingUrl = instanceIdentifier || 'http://localhost'; | ||
| // Traces will only be sent when running locally; change to instanceIdentifier once we can | ||
| // send trace data through the Crashlytics backend | ||
| const tracingUrl = 'http://localhost:4318'; |
There was a problem hiding this comment.
Hardcoding tracingUrl to http://localhost:4318 will cause issues in non-local environments, as it will always try to send traces to localhost. The accompanying comment // Traces will only be sent when running locally suggests this is intended for local development only, but the implementation does not reflect this. This could lead to failed network requests and potential performance issues in production.
To ensure this URL is only used during development, you could make its value conditional based on the environment. For example:
const tracingUrl =
process.env.NODE_ENV === 'development'
? 'http://localhost:4318'
: instanceIdentifier || 'http://localhost';This would use the local proxy URL for development and fall back to the previous behavior for other environments.
| const tracingUrl = 'http://localhost:4318'; | |
| const tracingUrl = process.env.NODE_ENV === 'development' ? 'http://localhost:4318' : (instanceIdentifier || 'http://localhost'); |
2 participants
