Skip to content

Include cache configs in connector configs.#10037

Open
itsrakhil wants to merge 5 commits intofirebase:mainfrom
itsrakhil:caching
Open

Include cache configs in connector configs.#10037
itsrakhil wants to merge 5 commits intofirebase:mainfrom
itsrakhil:caching

Conversation

@itsrakhil
Copy link
Contributor

Description

Scenarios Tested

Sample Commands

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the dataconnect module by integrating client-side caching capabilities across various SDK definitions. It introduces a standardized way to configure caching parameters such as age, size, and storage type, allowing different SDKs to leverage these settings for improved performance and data management.

Highlights

  • New CacheSettings Interface: Introduced a new CacheSettings interface to define client-side caching configurations, including maxAge, maxSize, and storage options.
  • Client-Side Caching for SDKs: Added an optional clientCache property, typed as CacheSettings, to AdminNodeSDK, JavascriptSDK, SwiftSDK, KotlinSDK, and DartSDK interfaces, enabling caching configuration for these SDKs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@itsrakhil itsrakhil changed the title Include Include cache configs in connector configs. Mar 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces caching settings for various Data Connect SDKs by adding a CacheSettings interface and a clientCache property to the SDK interfaces. The change is straightforward.

My main feedback is regarding the pull request's presentation. The title 'Include' is not descriptive, and the description is empty. The repository's GEMINI.md style guide provides clear instructions on how to structure commit messages and pull requests for clarity and to streamline the process. Please update the title and description to follow these guidelines.

I've also left a minor comment about trailing whitespace in the code.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant