Skip to content

Dupe of feat(mcp): revamp firebase init with orchestration API integration #9182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Dupe of feat(mcp): revamp firebase init with orchestration API integration #9182

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2b87a86
Add Firebase App provisioning API integration
TrCaM Sep 19, 2025
74f3687
Firebase MCP init tool schema change to support provisioning
TrCaM Sep 22, 2025
6c2b93a
Add methods to detect existing local apps from directories
TrCaM Sep 22, 2025
31e6327
Add methods to ensure local file locations for app provisioning
TrCaM Sep 22, 2025
b68727f
Wire up provisioning logic with fake API service - Verify logic first…
TrCaM Sep 22, 2025
1c2cc10
Archive mock provisioning service for future reference
TrCaM Sep 24, 2025
d411761
Complete first working version of revamped firebase init MCP tool
TrCaM Sep 24, 2025
a1cd048
Merge master into feature branch
TrCaM Sep 24, 2025
647eb87
Fix lint/formating - Add unit test for new firebase init tool
TrCaM Sep 24, 2025
3309d71
Fix lint/formating - Add unit test for new firebase init tool
TrCaM Sep 24, 2025
0a0af59
Minor pr fixes
joehan Sep 24, 2025
193d196
Adding missing files
joehan Sep 24, 2025
5f3a6b9
Merge branch 'master' into jh-provisioning
joehan Sep 24, 2025
e3afdee
Merge branch 'master' into jh-provisioning
joehan Sep 24, 2025
9814ef9
Merge branch 'master' into jh-provisioning
joehan Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/init/features/ailogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
export interface AiLogicInfo {
// Minimal interface - no configuration needed
[key: string]: unknown;
}

/**
*
*/
Comment on lines +6 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The JSDoc comment for this function is empty. Adding a brief description, even for a no-op function, improves code clarity and helps other developers understand its purpose without reading the implementation details.

Suggested change
/**
*
*/
/**
* Does nothing as AI Logic questions are handled by the MCP schema.
*/

export async function askQuestions(): Promise<void> {
// No-op - questions already handled by MCP schema
}

/**
*
*/
Comment on lines +13 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This JSDoc comment is empty. Please add a brief description to explain why this function is a no-op. This improves code documentation and maintainability.

Suggested change
/**
*
*/
/**
* Does nothing as AI Logic provisioning happens via API and requires no local config changes.
*/

export async function actuate(): Promise<void> {
// No-op - AI Logic provisioning happens via API, no local config changes needed
}
5 changes: 5 additions & 0 deletions src/init/features/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,8 @@ export {
actuate as apptestingAcutate,
} from "./apptesting";
export { doSetup as aitools } from "./aitools";
export {
askQuestions as aiLogicAskQuestions,
AiLogicInfo,
actuate as aiLogicActuate,
} from "./ailogic";
9 changes: 9 additions & 0 deletions src/init/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export interface SetupInfo {
dataconnectSdk?: features.DataconnectSdkInfo;
storage?: features.StorageInfo;
apptesting?: features.ApptestingInfo;
ailogic?: features.AiLogicInfo;
}

interface Feature {
Expand Down Expand Up @@ -96,11 +97,19 @@ const featuresList: Feature[] = [
askQuestions: features.apptestingAskQuestions,
actuate: features.apptestingAcutate,
},
{
name: "ailogic",
askQuestions: features.aiLogicAskQuestions,
actuate: features.aiLogicActuate,
},
{ name: "aitools", displayName: "AI Tools", doSetup: features.aitools },
];

const featureMap = new Map(featuresList.map((feature) => [feature.name, feature]));

/**
*
*/
Comment on lines +110 to +112
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This JSDoc comment is empty. Adding a description for the init function will improve code documentation and make it easier for others to understand its role in the initialization process.

Suggested change
/**
*
*/
/**
* Kicks off the init flow for the specified features.
*/

export async function init(setup: Setup, config: Config, options: any): Promise<any> {
const nextFeature = setup.features?.shift();
if (nextFeature) {
Expand Down
Loading
Loading