-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(mcp): AI Logic Init Feature (CLI Command and MCP Firebase Init Tool) #9185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… before real API integration
Summary of ChangesHello @TrCaM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables the initialization of Firebase AI Logic through both the Firebase CLI and the MCP Firebase init tool. It streamlines the process of setting up AI Logic by automating project and app provisioning, including platform detection, configuration file generation, and integration with the new Firebase provisioning API. This change simplifies the developer experience for integrating AI capabilities into their Firebase projects. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new ailogic
initialization feature to the Firebase CLI, enabling users to provision AI Logic resources via firebase init ailogic
and the MCP firebase_init
tool. The changes are comprehensive, including the core provisioning logic, integration with the init
command, a Zod schema for the MCP tool, and an extensive suite of unit tests.
My review focuses on improving consistency and code quality. I've suggested standardizing error handling to use FirebaseError
across the new feature for better error reporting and consistency with the existing codebase. I also pointed out a couple of minor areas for code cleanup and simplification.
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new 'AI Logic' initialization feature to the Firebase CLI, available through firebase init ailogic
and the MCP firebase_init
tool. The implementation includes a new provisioning API client to create Firebase apps and enable AI Logic, along with comprehensive unit tests for the new functionality. The changes are well-structured and integrate cleanly with the existing init
flow. My review focuses on improving error handling consistency and correcting a minor type definition. Overall, this is a solid contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more rounf of suggtions to simplify this code, but this looks very close
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all of the revisions
Simplify and temporary adaptation of #9174, limit to AI Logic enablement. As more products are supported via provisioning API, we will revert this back to #9174 later.
This PR introduces the AI Logic initialization feature, accessible via both the Firebase CLI command and the MCP Firebase init tool.
Key Features:
firebase init ailogic
, or via firebase_init MCP tool.firebaserc
file.overwrite_config
input.Limitations:
Testing with Gemini CLI
To test this feature using the Gemini CLI:
Clone PR with GitHub CLI:
Install and Link:
Update
~/.gemini/settings.json
:Add the following configuration:
Start Gemini CLI and try a prompt: