Use -o flag in recommended command

[joehan]

Description

Tiny improvement - with this flag, we'll automatically write to the platform appropriate file for you.

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor but significant improvement to the post-app creation workflow. By adding the -o flag to the recommended firebase apps:sdkconfig command, the system will now automatically write the configuration output to the appropriate platform-specific file, simplifying the setup process for developers.

Highlights

• Command Recommendation Update: The recommended firebase apps:sdkconfig command, displayed after creating a new app, now includes the -o flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the user experience by suggesting a more convenient command to get the app configuration file after creating an app. The change adds the -o flag to automatically save the file. My review includes a suggestion to add a clarification for the user about where the file is saved to prevent potential confusion, as the default location might not be the correct one within their project structure.

[gemini-code-assist]

Using the -o flag is a great UX improvement. However, it might be slightly misleading for users. The command will save the configuration file to the current working directory, which often isn't the correct location within a project (e.g., inside the app directory for Android). A user might assume the setup is complete when it's not.

Additionally, the preceding log on line 44, "You can run this command to print out your new app's Google Services config:", is now inaccurate since the command writes to a file instead of printing to standard output.

To make this clearer, I suggest adding a note for the user. Since I can only suggest changes to this line, my suggestion adds another log statement. Ideally, line 44 should also be updated to reflect that the command downloads a file.

  logger.info(`  firebase apps:sdkconfig ${appPlatform} ${appMetadata.appId} -o`);
  logger.info("  Note: This will download the config file to your current directory. You may need to move it to the correct location in your project.");

[maneesht]

I agree with this comment and just tested it out