Add common appUtils to augment get_environment with app level data #9236

schnecle · 2025-10-02T12:28:37Z

Description

Augment app utils to look for app ids in google-services files
Augment get_environment to output app ids

Scenarios Tested

Added unit test coverage for get_environment as well as the new apputils
Testing e2e locally on several different apps

Sample Commands

gemini
/crashlytics:connect

gemini
"What's my firebase environment look like?"

src/dataconnect/appFinder.ts

src/appUtils.ts

fredzqm · 2025-10-02T20:45:58Z

src/appUtils.ts

+  return {
+    platform: Platform.WEB,
+    directory: path.dirname(packageJsonFile),
+    frameworks: getFrameworksFromPackageJson(packageJson),


What about web? Do we want to call detectAppIdsForPlatform here?

I left web out because it's actually a little tricky. You can put the web configuration in any part of your code, so in the worst we would need to read through the entire code base. :/

If you've got ideas for how to do this more efficiently, I'm all ears!

Technically the same is true of flutter, but there is at least a convention around it.

I at least left a comment to that effect in the code.

src/appUtils.ts

fredzqm · 2025-10-02T20:48:33Z

src/appUtils.ts

+  platform: Platform;
+  directory: string;
+  appId?: string;
+  bundleId?: string;


Can there ever be a case where an app directory found >1 appId / bundleId?

If the underlying detectAppIdsForPlatform could potentially return multiple? Maybe it's safer to include all responses in the App struct.

We can log those anomaly at a higher level.

This can and does happen. In this case, I create multiple app instances. They are unique by appId and bundleId but may have the same platform and directory.

src/mcp/index.ts

src/mcp/tools/core/get_environment.spec.ts

joehan · 2025-10-06T19:09:17Z

src/mcp/tools/core/get_environment.ts

-${dump(getAllAccounts().map((account) => account.user.email)).trim()}
+Detected App IDs: ${detectedAppsMap.size > 0 ? `\n\n${dump(Object.fromEntries(detectedAppsMap)).trim()}\n` : "<NONE>"}
+Available Project Aliases (format: '[alias]: [projectId]'): ${Object.entries(rc.projects).length > 0 ? `\n\n${dump(rc.projects).trim()}\n` : "<NONE>"}
+Available Accounts: ${hasOtherAccounts ? `\n\n${dump(allAccounts).trim()}` : "<NONE>"}


Can we omit this header entirely if there are no other accounts logged in? Its a pretty rare use case in the first place.

joehan · 2025-10-06T19:10:17Z

src/mcp/tools/core/get_environment.ts

+If this project does not use Firebase tools that require a firebase.json file, no action is necessary.

-It looks like the current directory is not initialized as a Firebase project. The user will most likely want to:
+If this project uses Firebase tools that require a firebase.json file, the user will most likely want to:


Suggested change

If this project uses Firebase tools that require a firebase.json file, the user will most likely want to:

If this project uses Firebase services that require a firebase.json file, the user will most likely want to:

joehan · 2025-10-06T19:10:43Z

src/mcp/tools/core/get_environment.ts

-    : `\n# Empty Environment
+    : `\nNo firebase.json file was found.
+      
+If this project does not use Firebase tools that require a firebase.json file, no action is necessary.


Suggested change

If this project does not use Firebase tools that require a firebase.json file, no action is necessary.

If this project does not use Firebase services that require a firebase.json file, no action is necessary.

joehan · 2025-10-06T19:11:39Z

src/appUtils.spec.ts

+    const leanApp = Object.fromEntries(
+      Object.entries(app).filter((entry) => entry[1] !== undefined),
+    ) as App;
+    console.log(`LEAN APP: ${JSON.stringify(leanApp)}`);


joehan · 2025-10-06T19:13:26Z

src/appUtils.spec.ts

+  App,
+} from "./appUtils";
+
+const FLUTTER_CONFIG = `


Rather than having these configs as constants and setting up new directories every time, we should just add the test directories to the src/test/fixtures directory

joehan · 2025-10-06T19:17:48Z

src/appUtils.ts

@@ -0,0 +1,314 @@
+import * as fs from "fs-extra";


This file seems to duplicate a lot of what we've built in https://github.com/firebase/firebase-tools/blob/master/src/dataconnect/appFinder.ts - we really ought to unify the 2. I recall @fredzqm was looking at doing something like this

I have followup PR to do just that. I had some of that in here, but Fred recommended I take it out. See the conversation here: #9236 (comment)

github-project-automation bot added this to [Cloud] Extensions + Functions Oct 2, 2025

schnecle force-pushed the schnecle/get-mobile-environment branch 2 times, most recently from e951142 to d75b0a7 Compare October 2, 2025 20:05

schnecle marked this pull request as ready for review October 2, 2025 20:06

schnecle force-pushed the schnecle/get-mobile-environment branch 2 times, most recently from 0c515ca to a5bece4 Compare October 2, 2025 20:24

schnecle requested review from maxl0rd, mbleigh, joehan and fredzqm October 2, 2025 20:24

fredzqm reviewed Oct 2, 2025

View reviewed changes

maxl0rd reviewed Oct 2, 2025

View reviewed changes

src/mcp/index.ts Outdated Show resolved Hide resolved

src/mcp/tools/core/get_environment.spec.ts Show resolved Hide resolved

maxl0rd approved these changes Oct 6, 2025

View reviewed changes

github-project-automation bot moved this to Approved [PR] in [Cloud] Extensions + Functions Oct 6, 2025

schnecle added 3 commits October 6, 2025 18:31

Add common appUtils to augment get_environment with app level data

37dcd11

Responded to code review comments

1f34e98

Revert changes to dataconnect appFinder utils and manual project entry

2add8f1

schnecle force-pushed the schnecle/get-mobile-environment branch from 2ea682b to 2add8f1 Compare October 6, 2025 18:45

joehan reviewed Oct 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add common appUtils to augment get_environment with app level data #9236

Add common appUtils to augment get_environment with app level data #9236

schnecle commented Oct 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fredzqm Oct 2, 2025

Uh oh!

schnecle Oct 2, 2025

Uh oh!

schnecle Oct 3, 2025

Uh oh!

Uh oh!

fredzqm Oct 2, 2025

Uh oh!

schnecle Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

joehan Oct 6, 2025

Uh oh!

joehan Oct 6, 2025

Uh oh!

joehan Oct 6, 2025

Uh oh!

joehan Oct 6, 2025

Uh oh!

joehan Oct 6, 2025

Uh oh!

joehan Oct 6, 2025

Uh oh!

schnecle Oct 6, 2025

Uh oh!

Uh oh!

	If this project uses Firebase tools that require a firebase.json file, the user will most likely want to:
	If this project uses Firebase services that require a firebase.json file, the user will most likely want to:

	If this project does not use Firebase tools that require a firebase.json file, no action is necessary.
	If this project does not use Firebase services that require a firebase.json file, no action is necessary.

Add common appUtils to augment get_environment with app level data #9236

Are you sure you want to change the base?

Add common appUtils to augment get_environment with app level data #9236

Conversation

schnecle commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Scenarios Tested

Sample Commands

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

schnecle commented Oct 2, 2025 •

edited

Loading