-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Updated Firestore Emulator to v1.20.2 #9241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @harshyyy21, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Firestore Emulator to its latest version, v1.20.2. This update incorporates minor bug fixes, particularly for Datastore Mode, enhancing the emulator's reliability and functionality for developers. The change involves updating the emulator's version, expected file size, and checksum in the configuration, along with a corresponding changelog entry. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Firestore emulator to version 1.20.2. The changes are mostly correct, but there is a significant oversight in src/emulator/downloadableEmulatorInfo.json
. The SHA256 checksum for the emulator JAR was not updated along with the other download details. This should be corrected to ensure data integrity and prevent potential issues in the future.
Looks like this is breaking the integration tests - does this require a higher version of java than previously?
|
Description
This PR updates the Firestore Emulator to v1.20.2
Scenarios Tested