Skip to content

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Oct 6, 2025

In case the user doesn't have the firebase CLI downloaded, we want to suggest them a command that will succeed on their machine. The reason we can't just use firebase is some users may have run the MCP server via npx, and don't have firebase installed globally. In the future, we'd like to detect how you ran the MCP server, and use that so that the CLI doesn't run commands that results in an install.

Copy link
Contributor

Summary of Changes

Hello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the internal prompts for Firebase operations by switching from direct firebase command invocations to npx firebase@latest. This adjustment addresses scenarios where the Firebase CLI might not be globally installed on a user's system, providing a more resilient and accessible way to execute commands like login and deploy by temporarily fetching and running the latest CLI version.

Highlights

  • Firebase CLI Command Execution: All Firebase CLI commands within the mcp prompts have been updated to use npx firebase@latest instead of a direct firebase call.
  • Improved User Experience: This change ensures that users can execute Firebase commands even if the Firebase CLI is not globally installed, by leveraging npx to run the latest version of the CLI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MCP prompts to use npx firebase@latest instead of just firebase. This is a great improvement as it allows users to run firebase commands without having the firebase-tools CLI globally installed. The changes are applied consistently across the deploy and crashlytics prompts. My feedback focuses on improving stability by pinning to a major version of the Firebase CLI instead of using @latest, to prevent unexpected breaking changes. The PR also includes several beneficial whitespace cleanups.

@samedson samedson requested review from mbleigh and joehan October 6, 2025 14:27
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like what we're going here, but I think we can just do it all in one fell swoop. #9265 adds a cached call to check if 'firebase' is installed, and falls back to npx only if it is not installed.

@samedson
Copy link
Contributor Author

samedson commented Oct 6, 2025

Sweet just approved the other one @joehan

* Sometime use firebase

* Small fix
@samedson samedson changed the title Update MCP prompts to use npx firebase Update MCP prompts to fallback to npx firebase-tools if firebase isn't installed Oct 6, 2025
Copy link
Contributor

@schnecle schnecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the Crashlytics prompt! 👍

@samedson
Copy link
Contributor Author

samedson commented Oct 6, 2025

Ok I'm getting Error: spawnSync firebase --version ENOENT

I think it's due to weirdness in my path. Either way, this is a good change to merge.

@samedson samedson enabled auto-merge (squash) October 6, 2025 18:58
@samedson samedson merged commit 0fc5903 into master Oct 6, 2025
48 checks passed
@samedson samedson deleted the samedson-npx-commands branch October 6, 2025 19:10
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants