-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update MCP prompts to fallback to npx firebase-tools if firebase isn't installed #9261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @samedson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the internal prompts for Firebase operations by switching from direct Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the MCP prompts to use npx firebase@latest
instead of just firebase
. This is a great improvement as it allows users to run firebase commands without having the firebase-tools
CLI globally installed. The changes are applied consistently across the deploy
and crashlytics
prompts. My feedback focuses on improving stability by pinning to a major version of the Firebase CLI instead of using @latest
, to prevent unexpected breaking changes. The PR also includes several beneficial whitespace cleanups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like what we're going here, but I think we can just do it all in one fell swoop. #9265 adds a cached call to check if 'firebase' is installed, and falls back to npx only if it is not installed.
Sweet just approved the other one @joehan |
* Sometime use firebase * Small fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the Crashlytics prompt! 👍
Ok I'm getting I think it's due to weirdness in my path. Either way, this is a good change to merge. |
In case the user doesn't have the firebase CLI downloaded, we want to suggest them a command that will succeed on their machine. The reason we can't just use
firebase
is some users may have run the MCP server via npx, and don't have firebase installed globally. In the future, we'd like to detect how you ran the MCP server, and use that so that the CLI doesn't run commands that results in an install.