Refactor dataconnect to use the common appUtils models#9286
Merged
Conversation
fredzqm
reviewed
Oct 8, 2025
| // Detect what platform based on current user | ||
| let targetPlatform = await getPlatformFromFolder(appDir); | ||
| if (targetPlatform === Platform.NONE) { | ||
| let targetPlatforms = await getPlatformsFromFolder(appDir); |
Contributor
There was a problem hiding this comment.
@maneesht is the right person to take a look at management/apps.ts~
I took a glance. Don't see any issues.
b6bdceb to
79b8215
Compare
79b8215 to
0eca209
Compare
fredzqm
approved these changes
Oct 9, 2025
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request does a great job of refactoring the app detection logic into a common appUtils module, which improves code organization and reusability. The increased test coverage is also a welcome addition. I've found a critical issue with a new deduplication function and a couple of other points that I've detailed in the specific comments. Once these are addressed, this will be a solid improvement.
joehan
reviewed
Oct 9, 2025
joehan
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Scenarios Tested
Sample Commands