-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add isAvailable function for dynamic tool availability #9316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8e39a39
feat: Add isAvailable function for dynamic tool availability
google-labs-jules[bot] 80f567a
Create default availability functions and caching on api availability
schnecle d6bd11d
Respond to code review comments
schnecle f178961
Merge branch 'master' into feat/mcp-tool-availability
visumickey 7ec5dad
Merge branch 'master' into feat/mcp-tool-availability
joehan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import { expect } from "chai"; | ||
| import * as sinon from "sinon"; | ||
| import { prompt } from "./prompt"; | ||
| import * as availability from "./util/availability"; | ||
| import { McpContext } from "./types"; | ||
|
|
||
| describe("prompt", () => { | ||
| let sandbox: sinon.SinonSandbox; | ||
| let getDefaultFeatureAvailabilityCheckStub: sinon.SinonStub; | ||
|
|
||
| // A mock context object for calling isAvailable functions. | ||
| const mockContext = {} as McpContext; | ||
|
|
||
| beforeEach(() => { | ||
| sandbox = sinon.createSandbox(); | ||
| // Stub the function that provides the default availability checks. | ||
| getDefaultFeatureAvailabilityCheckStub = sandbox.stub( | ||
| availability, | ||
| "getDefaultFeatureAvailabilityCheck", | ||
| ); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| sandbox.restore(); | ||
| }); | ||
|
|
||
| it("should create a prompt with the correct shape and properties", () => { | ||
| const testFn = async () => []; | ||
| const testPrompt = prompt( | ||
| "core", | ||
| { | ||
| name: "test_prompt", | ||
| description: "A test prompt", | ||
| }, | ||
| testFn, | ||
| ); | ||
|
|
||
| expect(testPrompt.mcp.name).to.equal("test_prompt"); | ||
| expect(testPrompt.mcp.description).to.equal("A test prompt"); | ||
| expect(testPrompt.fn).to.equal(testFn); | ||
| }); | ||
|
|
||
| it("should use the default availability check for the feature if none is provided", () => { | ||
| // Arrange: Prepare a fake default check function to be returned by our stub. | ||
| const fakeDefaultCheck = async () => true; | ||
| getDefaultFeatureAvailabilityCheckStub.withArgs("core").returns(fakeDefaultCheck); | ||
|
|
||
| // Act: Create a prompt WITHOUT providing an isAvailable function. | ||
| const testPrompt = prompt("core", { name: "test_prompt" }, async () => []); | ||
|
|
||
| // Assert: The prompt's isAvailable function should be the one our stub provided. | ||
| expect(testPrompt.isAvailable).to.equal(fakeDefaultCheck); | ||
|
|
||
| // Assert: The factory function should have called the stub to get the default. | ||
| expect(getDefaultFeatureAvailabilityCheckStub.calledOnceWith("core")).to.be.true; | ||
| }); | ||
|
|
||
| it("should override the default and use the provided availability check", async () => { | ||
| const fakeDefaultCheck = async () => true; | ||
| const overrideCheck = async () => false; | ||
| getDefaultFeatureAvailabilityCheckStub.withArgs("core").returns(fakeDefaultCheck); | ||
|
|
||
| const testPrompt = prompt( | ||
| "core", | ||
| { | ||
| name: "test_prompt", | ||
| }, | ||
| async () => [], | ||
| overrideCheck, | ||
| ); | ||
|
|
||
| expect(testPrompt.isAvailable).to.equal(overrideCheck); | ||
|
|
||
| const isAvailable = await testPrompt.isAvailable(mockContext); | ||
| expect(isAvailable).to.be.false; | ||
|
|
||
| expect(getDefaultFeatureAvailabilityCheckStub.notCalled).to.be.true; | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.