Skip to content

feat: Add hosting to firebase_init MCP tool, and use it in the init prompt #9375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joehan merged 6 commits into from
Oct 23, 2025
Merged

feat: Add hosting to firebase_init MCP tool, and use it in the init prompt #9375

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
074471d
feat: Add hosting to firebase_init MCP tool
google-labs-jules[bot] Oct 23, 2025
2c1bca4
Improvements and changelog
joehan Oct 23, 2025
d62059f
More arg renaming for consistency, and use the tool in init prompt
joehan Oct 23, 2025
a1b5617
Move deploy up into backend guide
joehan Oct 23, 2025
3164f0c
format
joehan Oct 23, 2025
2f5c0e2
typo
joehan Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/mcp/tools/core/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,27 @@
})
.optional()
.describe("Enable Firebase AI Logic feature for existing app"),
hosting: z
.object({
site: z

Check failure on line 145 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Replace `⏎··············.string()⏎··············.optional()⏎··············` with `.string().optional()`

Check failure on line 145 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

Replace `⏎··············.string()⏎··············.optional()⏎··············` with `.string().optional()`

Check failure on line 145 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Replace `⏎··············.string()⏎··············.optional()⏎··············` with `.string().optional()`

Check failure on line 145 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Replace `⏎··············.string()⏎··············.optional()⏎··············` with `.string().optional()`

Check failure on line 145 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

Replace `⏎··············.string()⏎··············.optional()⏎··············` with `.string().optional()`
.string()
.optional()
.describe("The ID of the hosting site to configure."),
public: z
.string()
.optional()
.default("public")
.describe("The directory to use as the public root."),
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

public is a reserved keyword in TypeScript. While it's valid to use it as a property name here, it can lead to issues, for example with object destructuring (const { public } = ... is invalid). It's better to use a non-reserved name like publicDirectory to improve code clarity and prevent potential errors. This change will also require an update on line 247.

Suggested change
public: z
.string()
.optional()
.default("public")
.describe("The directory to use as the public root."),
publicDirectory: z
.string()
.optional()
.default("public")
.describe("The directory to use as the public root."),

spa: z

Check failure on line 154 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Replace `⏎··············.boolean()⏎··············.optional()⏎··············.default(false)⏎··············` with `.boolean().optional().default(false)`

Check failure on line 154 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

Replace `⏎··············.boolean()⏎··············.optional()⏎··············.default(false)⏎··············` with `.boolean().optional().default(false)`

Check failure on line 154 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (22) 

Replace `⏎··············.boolean()⏎··············.optional()⏎··············.default(false)⏎··············` with `.boolean().optional().default(false)`

Check failure on line 154 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Replace `⏎··············.boolean()⏎··············.optional()⏎··············.default(false)⏎··············` with `.boolean().optional().default(false)`

Check failure on line 154 in src/mcp/tools/core/init.ts

View workflow job for this annotation

GitHub Actions / unit (20) 

Replace `⏎··············.boolean()⏎··············.optional()⏎··············.default(false)⏎··············` with `.boolean().optional().default(false)`
.boolean()
.optional()
.default(false)
.describe("Configure as a single-page app."),
})
.optional()
.describe(
"Provide this object to initialize Firebase Hosting in this project directory.",
),
}),
}),
annotations: {
Expand Down Expand Up @@ -219,6 +240,14 @@
displayName: appData.displayName,
};
}
if (features.hosting) {
featuresList.push("hosting");
featureInfo.hosting = {
newSiteId: features.hosting.site,
public: features.hosting.public,
spa: features.hosting.spa,
};
}
const setup: Setup = {
config: config?.src,
rcfile: rc?.data,
Expand Down
Loading