Return arrays from listTesters() and listGroups().

[kaibolay]

Description

Internal cleanup: Improved API of appdistribution/client.ts.

Scenarios Tested

• Unit tests (appdistribution/client.spec.ts)
• firebase appdistribution:testers:list
• firebase appdistribution:groups:list

[gemini-code-assist]

Summary of Changes

Hello @kaibolay, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on an internal API cleanup within the appdistribution module. It refactors the listTesters and listGroups functions to provide a more direct and intuitive interface by returning arrays of data directly, rather than nested within a response object. This change improves the usability of these client methods while ensuring backward compatibility for the CLI commands that consume them.

Highlights

• API Simplification: The listTesters() and listGroups() methods in appdistribution/client.ts now directly return arrays of Tester and Group objects, respectively, instead of wrapping them in a response object.
• Code Cleanup: This change removes the intermediate ListTestersResponse and ListGroupsResponse objects, streamlining the API and reducing boilerplate.
• Command Line Interface (CLI) Adaptation: The appdistribution:testers:list and appdistribution:groups:list commands have been updated to handle the new array return types from the client, re-wrapping them into the expected response object for consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the listTesters() and listGroups() methods in appdistribution/client.ts to return arrays directly, which simplifies the client API. The changes are well-implemented across the client, tests, and command files. I've identified a type safety issue in listTesters and suggested some refactoring in the command files to improve code structure and readability. Overall, a good cleanup.