Skip to content

Prefer the non-deprected firebase:appdistribution:groups:* #9396

Merged
kaibolay merged 1 commit intomasterfrom
kb/groups
Oct 28, 2025
Merged

Prefer the non-deprected firebase:appdistribution:groups:* #9396
kaibolay merged 1 commit intomasterfrom
kb/groups

Conversation

@kaibolay
Copy link
Contributor

@kaibolay kaibolay commented Oct 28, 2025

Description

firebase:appdistribution:group:* (singular :group:) is deprecated. firebase:appdistribution:groups:* (plural :groups:) is preferred.

Scenarios Tested

  • firebase --help
  • firebase irebase:appdistribution:groups:list
  • firebase irebase:appdistribution:group:list

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kaibolay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Firebase CLI's command registration for App Distribution groups. It transitions from using the deprecated "firebase:appdistribution:group:" commands to the recommended "firebase:appdistribution:groups:" commands. The change ensures that the CLI adheres to current best practices while maintaining full backward compatibility by aliasing the old command structure to the new one, minimizing disruption for users.

Highlights

  • Deprecated Command Usage: Updated the Firebase CLI to prefer the non-deprecated "firebase:appdistribution:groups:" commands over the singular "firebase:appdistribution:group:" commands.
  • Backward Compatibility: Ensured backward compatibility by aliasing the deprecated singular "group" object to the new plural "groups" object, preventing breaking changes for existing scripts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the deprecation of firebase:appdistribution:group:* by making firebase:appdistribution:groups:* the primary command namespace. The changes in src/commands/index.ts properly establish client.appdistribution.groups and then alias client.appdistribution.group to it for backward compatibility. This is a clean and effective way to handle the deprecation and aligns with the existing command aliases. The code is clear and correct.

… deprecated `firebase:appdistribution:group:*`.
@kaibolay kaibolay enabled auto-merge (squash) October 28, 2025 14:54
@kaibolay kaibolay merged commit be433bc into master Oct 28, 2025
50 checks passed
@kaibolay kaibolay deleted the kb/groups branch October 28, 2025 15:00
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants